From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <bbrezillon@kernel.org>
Cc: Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 2/2] mtd: rework partitions handling
Date: Tue, 22 Jan 2019 12:12:36 +0100 [thread overview]
Message-ID: <20190122121236.341d22f4@xps13> (raw)
In-Reply-To: <20190117212916.70ad1269@bbrezillon>
Hi Boris,
> > int mtd_block_markbad(struct mtd_info *mtd, loff_t ofs)
> > {
> > - if (!mtd->_block_markbad)
> > + struct mtd_info *master = mtd_get_master(mtd);
> > + int ret;
> > +
> > + if (!master->_block_markbad)
> > return -EOPNOTSUPP;
> > if (ofs < 0 || ofs >= mtd->size)
> > return -EINVAL;
> > if (!(mtd->flags & MTD_WRITEABLE))
> > return -EROFS;
> > - return mtd->_block_markbad(mtd, ofs);
> > +
> > + ret = master->_block_markbad(master, mtd_get_master_offset(mtd, ofs));
> > + if (ret)
> > + return ret;
> > +
> > + while (mtd->parent) {
> > + mtd->ecc_stats.badblocks++;
> > + mtd = mtd->parent;
> > + }
>
> Not exactly related to this patch, but if we mark a block bad on the
> master device this information is not propagated to parts exposing this
> block.
No but is this important? It is very quick to get up to the master
device so the penalty for doing that is almost non-existent.
Other comments addressed, thanks for the review.
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-01-22 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190117152929.28256-1-miquel.raynal@bootlin.com>
[not found] ` <20190117152929.28256-2-miquel.raynal@bootlin.com>
2019-01-17 20:29 ` [PATCH v3 2/2] mtd: rework partitions handling Boris Brezillon
2019-01-22 11:12 ` Miquel Raynal [this message]
2019-01-21 10:03 ` [PATCH v3 1/2] mtd: partitions: clarify __mtd_del_partition() name Boris Brezillon
2019-01-22 11:01 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122121236.341d22f4@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox