From: Boris Brezillon <bbrezillon@kernel.org>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Marek Vasut <marek.vasut@gmail.com>,
"richard@nod.at" <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 3/4] mtd: rawnand: ESMT: Also use the last page for bad block markers
Date: Tue, 22 Jan 2019 17:27:32 +0100 [thread overview]
Message-ID: <20190122172732.6cbcffec@bbrezillon> (raw)
In-Reply-To: <20190122112258.20042-4-frieder.schrempf@kontron.de>
On Tue, 22 Jan 2019 11:23:32 +0000
Schrempf Frieder <frieder.schrempf@kontron.de> wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> It is known that some ESMT SLC NANDs have been shipped
> with the factory bad block markers in the first or last page
> of the block, instead of the first or second page. To be on
> the safe side, let's check all three locations.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
> ---
> drivers/mtd/nand/raw/nand_esmt.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_esmt.c b/drivers/mtd/nand/raw/nand_esmt.c
> index 99a8092969a7..b37e0b5af5ae 100644
> --- a/drivers/mtd/nand/raw/nand_esmt.c
> +++ b/drivers/mtd/nand/raw/nand_esmt.c
> @@ -36,7 +36,14 @@ static void esmt_nand_decode_id(struct nand_chip *chip)
> static int esmt_nand_init(struct nand_chip *chip)
> {
> if (nand_is_slc(chip))
> - chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE;
> + /*
> + * It is known that some ESMT SLC NANDs have been shipped
> + * with the factory bad block markers in the first or last page
> + * of the block, instead of the first or second page. To be on
> + * the safe side, let's check all three locations.
> + */
> + chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE |
> + NAND_BBM_LASTPAGE;
>
> return 0;
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-01-22 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 11:23 [PATCH v2 0/4] mtd: rawnand: Support bad block markers in first, second or last page Schrempf Frieder
2019-01-22 11:23 ` [PATCH v2 1/4] mtd: nand: Always store info about bad block markers in chip struct Schrempf Frieder
2019-01-22 13:13 ` Schrempf Frieder
2019-01-22 13:18 ` Boris Brezillon
2019-01-22 13:53 ` Schrempf Frieder
2019-01-22 11:23 ` [PATCH v2 2/4] mtd: rawnand: Support bad block markers in first, second or last page Schrempf Frieder
2019-01-22 16:26 ` Boris Brezillon
2019-01-22 11:23 ` [PATCH v2 3/4] mtd: rawnand: ESMT: Also use the last page for bad block markers Schrempf Frieder
2019-01-22 16:27 ` Boris Brezillon [this message]
2019-01-22 11:23 ` [PATCH v2 4/4] mtd: rawnand: AMD: " Schrempf Frieder
2019-01-22 16:28 ` Boris Brezillon
2019-01-22 13:09 ` [PATCH v2 0/4] mtd: rawnand: Support bad block markers in first, second or last page Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122172732.6cbcffec@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@kontron.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).