Re: [PATCH] mtd: spinand: Add support for GigaDevice GD5F1GQ4UC

Boris Brezillon
2019-01-23T08:55:20Z

On Wed, 23 Jan 2019 09:23:47 +0100
Stefan Roese <sr@denx.de> wrote:

> > This one doesn't, incremental mode (-i) should.
>
> Here you go:
>
> # ./nandbiterrs /dev/mtd5 -k -i
> incremental biterrors test
> Failed to recover 1 bitflips
> Read error after 0 bit errors per page
>
> I'm still unsure how this helps here.

It helps, it tells us the ECC doesn't work properly (fails to recover
one bitflip), or maybe it's the raw accessors that don't don't work.

> Is there anything else I should test?

Add traces to the get_ecc_status() func and print the status value.
>
> www.gigadevice.com/datasheet/gd5f1gq4xexxg/
>
> Looking again, its "GD5F1GQ4UExxG" on the GigaDevice webpage and
> in the datasheet, 0xd1 references "GD5F1GQ4U". So I should change
> the chip name to "GD5F1GQ4UExxG" instead.

Yes, please do that.

>
> Sorry for the confusion here.

No problem.

>
> I'll try to enhance the ecc_get_status() function to also read the
> status register at addr 0xf0 for the ECCSE0/1 bits to determine a
> more fine grained ECC information for this chip.

Let's first figure out why nandbiterrs fails to correct 1 bitflip.