Re: [PATCH v3 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory

Tudor.Ambarus
2019-02-02T08:47:40Z

On 02/02/2019 09:15 AM, Boris Brezillon wrote:
> On Sat, 2 Feb 2019 04:07:39 +0000
> <Tudor.Ambarus@microchip.com> wrote:
>
>> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>>
>> Naming clocks is a good practice. Make "pclk" madatory even if
>> we support unnamed clock in the driver, to be backward compatible
>> with old DTs.
>>
>> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> ---
>> v3: new patch
>>
>> Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
>> index e9dae6264d89..1de54e87f5d6 100644
>> --- a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
>> +++ b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
>> @@ -9,6 +9,7 @@ Required properties:
>> - qspi_mmap: memory mapped address space
>> - interrupts: Should contain the interrupt for the device.
>> - clocks: The phandle of the clock needed by the QSPI controller.
>> +- clock-names: Should contain "pclk" for the peripheral clock.
>> - #address-cells: Should be <1>.
>> - #size-cells: Should be <0>.
>>
>> @@ -20,6 +21,7 @@ spi@f0020000 {
>> reg-names = "qspi_base", "qspi_mmap";
>> interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
>> clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
>> + clock-names = "pclk"
>
> Missing semicolon. Once fixed you can add
>
> Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>

will do, thanks!

>
>> #address-cells = <1>;
>> #size-cells = <0>;
>> pinctrl-names = "default";
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/