From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Boris Brezillon <bbrezillon@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock support
Date: Thu, 7 Feb 2019 23:20:28 +0100 [thread overview]
Message-ID: <20190207232028.26b4a7f5@xps13> (raw)
In-Reply-To: <ea245b53-59c9-0d7f-f33a-44aa93db99ac@kernel.org>
Hi Dinh,
Dinh Nguyen <dinguyen@kernel.org> wrote on Thu, 7 Feb 2019 12:17:50
-0600:
> On 2/5/19 7:18 AM, Miquel Raynal wrote:
> > Hi Dinh,
> >
> > Boris Brezillon <bbrezillon@kernel.org> wrote on Thu, 31 Jan 2019
> > 18:26:44 +0100:
> >
> >> Hi Dinh,
> >>
> >> On Thu, 31 Jan 2019 11:24:16 -0600
> >> Dinh Nguyen <dinguyen@kernel.org> wrote:
> >>
> >>> On 1/28/19 4:20 AM, Miquel Raynal wrote:
> >>>> Hi Dinh,
> >>>>
> >>>> Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Wed, 16 Jan
> >>>> 2019 10:27:11 +0900:
> >>>>
> >>>>> (+CC Dinh Nguyen)
> >>>>>
> >>>>> On Tue, Jan 15, 2019 at 5:22 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >>>>>>
> >>>>>> Hi Masahiro,
> >>>>>>
> >>>>>> Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Tue, 15 Jan
> >>>>>> 2019 17:11:34 +0900:
> >>>>>>
> >>>>>>> Commit 6f1fe97bec34 ("mtd: rawnand: denali_dt: add more clocks based
> >>>>>>> on IP datasheet") introduced a more correct binding that requires
> >>>>>>> three named clocks.
> >>>>>>>
> >>>>>>> Now that all upstream DT files migrated over to it, remove the single
> >>>>>>> anonymous clock support.
> >>>>>>
> >>>>>> I would love to do that but I think this is against the "DT backward
> >>>>>> compatibility rule".
> >>>>>
> >>>>> Yeah, I know this rule, but we break DT binding from time to time.
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Anyway, IIRC it is accepted that this kind of
> >>>>>> rule might be broken if decided per the arch-maintainer (in this
> >>>>>> case, you I suppose). So if this is really what you want, I'll queue
> >>>>>> it.
> >>>>>
> >>>>> My platform is fine, but this driver is used by SOCFPGA boards as well.
> >>>>>
> >>>>> I CCed the SOCFPGA maintainer, Dinh Nguyen.
> >>>>>
> >>>>
> >>>> Gentle ping on this topic.
> >>>>
> >>>
> >>> This patch looks fine to be. Feel free to add:
> >>>
> >>> Tested-by: Dinh Nguyen <dinguyen@kernel.org>
> >>
> >> I think Miquel is waiting for an Acked-by to confirm that you're okay
> >> breaking backward compat with old DT.
> >
> > Yes, I am waiting for your Acked-by.
> >
> >
>
> Acked-by: Dinh Nguyen <dinguyen@kernel.org>
>
> Dinh
Applied to nand/next.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-02-07 22:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 8:11 [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock support Masahiro Yamada
2019-01-15 8:22 ` Miquel Raynal
2019-01-16 1:27 ` Masahiro Yamada
2019-01-21 9:11 ` Miquel Raynal
2019-01-28 10:20 ` Miquel Raynal
2019-01-30 16:20 ` Dinh Nguyen
2019-01-31 17:24 ` Dinh Nguyen
2019-01-31 17:26 ` Boris Brezillon
2019-02-05 13:18 ` Miquel Raynal
2019-02-07 18:17 ` Dinh Nguyen
2019-02-07 22:20 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207232028.26b4a7f5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dinguyen@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).