From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC0DC43381 for ; Thu, 21 Feb 2019 12:08:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5301D20855 for ; Thu, 21 Feb 2019 12:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jHxF7yP+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NjEMWwKM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5301D20855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v6ctU4PjX8wdomhlB1dpVCgG+gOIyEReEtPjmxT/Lnk=; b=jHxF7yP+MkDaIz PFY+rW11G5mzAEFstcQf0KjVIu+mOhKTxiof8q5xQwPewTy4wy6YRqmpdvLaF6xrniWu5p9WFa8SH afMsMypajBE2m1/DJCkTyS7JWDoyy+S6c1s2t4nmme3tgv/zq/kS84ZFozzuyB/88iDE5h5/uIAE6 IYJW3svPpQiEEyhLuvgbxIbUgbwaH6nxoc7+JKozLfBwpCRKnsXzq0oBwVg5qvtKeq01vJU0z1Gcs KnYBKOguxtzeotxzWVfJJ8sDGeibV/Dc5kw11Jf51cLieEtjsj0ZDcNXsNC3zKnCa2Ve4hrLXrbCR Pp1SYYFaF3SDGiqVW9XQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwn9V-0006Do-3b; Thu, 21 Feb 2019 12:08:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwn9K-00064x-70; Thu, 21 Feb 2019 12:08:25 +0000 Received: from localhost (unknown [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58EB720855; Thu, 21 Feb 2019 12:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550750901; bh=fpaFN2eK2DE98FA8SCXmmCYjNYjUVZWlfRrxsUVSUdU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NjEMWwKMawag2vuZ4XsYkLrWUF8tnjzh6jf6j5qspq2gZDuMJy7TOIZmA/xHGR0Mg RNMXbI/WqQCjucarzwNWB5Q4HTdqvUUqh61hDGX+FX57S+eCeGC13uBnPV/ot6Me41 iWHb88gByPnR0zlITYWWfl9EdRiBkhKTt+LMVrM8= Date: Thu, 21 Feb 2019 13:08:15 +0100 From: Boris Brezillon To: Miquel Raynal Subject: Re: [RFC PATCH 02/27] mtd: nand: Compile in the NAND core by default Message-ID: <20190221130815.7bd550dd@kernel.org> In-Reply-To: <20190221124628.3538ecb0@xps13> References: <20190221100216.25255-1-miquel.raynal@bootlin.com> <20190221100216.25255-3-miquel.raynal@bootlin.com> <20190221115554.315fbd9b@kernel.org> <20190221120610.5abb49ae@xps13> <20190221121437.7c551bc5@kernel.org> <20190221124628.3538ecb0@xps13> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190221_040823_904836_CD52E7CA X-CRM114-Status: GOOD ( 27.52 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mason Yang , Vignesh R , Tudor Ambarus , Julien Su , Richard Weinberger , Schrempf Frieder , Marek Vasut , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 21 Feb 2019 12:46:28 +0100 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Thu, 21 Feb 2019 > 12:14:37 +0100: > > > On Thu, 21 Feb 2019 12:06:10 +0100 > > Miquel Raynal wrote: > > > > > Hi Boris, > > > > > > Boris Brezillon wrote on Thu, 21 Feb 2019 > > > 11:55:54 +0100: > > > > > > > On Thu, 21 Feb 2019 11:01:51 +0100 > > > > Miquel Raynal wrote: > > > > > > > > > Force the NAND core be compiled-in when using any kind of NAND. > > > > > > > > Why? > > > > > > Because all the logic that comes later in the series relies on this > > > change. I need the NAND core to be compiled-in, > > > > Hm, not exactly compiled-in as it can still be selected as a module. > > Yes, do you think it is a problem? Yes, it is, at least for the SPI NAND case (and soon the RAW NAND case too) since you remove the select but don't add a depends on. If you select NAND_CORE as a module and SPI_NAND compiled-in => BOOM! > > > > > > as well the ECC engine > > > core, as well as everything that is shared between raw NAND and > > > SPI-NAND which I move in the NAND core. > > > > Yes, the core is required for SPI NAND and soon will be for RAW NAND, > > but I still don't see the problem with the "select NAND_CORE" approach, > > sorry. > > > > > > > > > > > > > > > > > > > Also remove the redundant dependencies on MTD which is enforced by the > > > > > game of the if/endif blocs. > > > > > > > > > > Signed-off-by: Miquel Raynal > > > > > --- > > > > > drivers/mtd/nand/Kconfig | 12 ++++++++++-- > > > > > drivers/mtd/nand/onenand/Kconfig | 1 - > > > > > drivers/mtd/nand/raw/Kconfig | 1 - > > > > > drivers/mtd/nand/spi/Kconfig | 1 - > > > > > 4 files changed, 10 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > > > > > index 495751ed3fd7..e8d26a715922 100644 > > > > > --- a/drivers/mtd/nand/Kconfig > > > > > +++ b/drivers/mtd/nand/Kconfig > > > > > @@ -1,6 +1,14 @@ > > > > > -config MTD_NAND_CORE > > > > > - tristate > > > > > +menuconfig MTD_NAND_CORE > > > > > + tristate "NAND" > > > > > > > > Definitely not something we want to expose in menuconfig. > > > > > > I considered the NAND core as essential when using raw NAND and > > > SPI-NAND. > > > > It is needed for SPI NAND, and will be for raw NAND for sure, but I > > still see no reasons for turning it into a user-visible option. > > > > > Hence, turning it into a menuconfig option make the whole > > > NAND subsystem available (or not) and will appear in a different > > > "menuconfig page", which really enhances the readability. > > > > That's a different thing, and I have no problem with adding an extra > > level in the Kconfig hierarchy. > > Then why not using this symbol? I don't get why you are opposed. Because, not only you're forcing onenand users to pull the nand core code in, which is not needed until the conversion to the generic NAND layer is done, but you're actually forcing that for all existing defconfigs because of your "default y" approach. Also, I don't see what's the benefit of letting users know about this intermediate framework when all they care about is supporting a specific class of devices. > > So you would like a config NAND_CORE (invisible) and a visible > menuconfig NAND? And all entries in the NAND menu selecting NAND_CORE? Not all entries, just SPI NAND, and soon, raw NAND. And yes, I'd prefer that. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/