From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE39C10F05 for ; Sun, 17 Mar 2019 20:07:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08ED620896 for ; Sun, 17 Mar 2019 20:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FajAtUMo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hPTmWATg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08ED620896 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ot5z9TL3nqtKJEbQzmDizVn9Cm8f7PZytTCPqvY2iaM=; b=FajAtUMoJ5DhdS U1Z7h81Kl7tfX6qS7h838FiAMN1kgK1oudbF+Bug7cbppBSoeMn6sgrSfhhb1kowmpBcN4DkxkNhv vtnz7Nwlp2EKtzNd8g/+BTBWc3Uz4zGdSKJvC4ITH703JLZKrUSpgsaRQxdmSp6orF2WUygChF5YA SXu2zjFmHhLo55dBflOgKKKHEanGAh3gSCZKwfidBypersZsynICoxRDcHATp2VpIm2iTN2dYyAFy /kfhtZlRnwwtMufB0xYow7aicHhK9EVUchzkMKI78/hMDuyP3FWrTsgi2T7dLdkoCx+uYV67sWoGi QMgiAco4cPeWxdw+ID4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5c3z-0003hi-Cf; Sun, 17 Mar 2019 20:07:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5c3u-0003g6-0I for linux-mtd@lists.infradead.org; Sun, 17 Mar 2019 20:07:14 +0000 Received: from sol.localdomain (c-107-3-167-184.hsd1.ca.comcast.net [107.3.167.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B4EE20896; Sun, 17 Mar 2019 20:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552853232; bh=RFKQxI9t4mNy+XnhJS/exqAldMOtCTqbOtaw+MeWgvU=; h=From:To:Cc:Subject:Date:From; b=hPTmWATgDPoXkE3IkIQbrPsG9wTYN7583dYOqpl9HyGgMt1IuLtrRqcBOvn0TUjfJ 9a/QZPPUylcNLz9gY42rxgbiUOrybK+nqE5jmydUxcSwVyDvnwZ1SaQmpH6pUS4sSJ TMfnFgRiQNKgkpBD4T4uJsm2PwFBm/TlWBfqgBmI= From: Eric Biggers To: linux-fscrypt@vger.kernel.org Subject: [PATCH 0/5] fscrypt: d_revalidate fixes and cleanups Date: Sun, 17 Mar 2019 13:04:39 -0700 Message-Id: <20190317200444.5967-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190317_130714_068058_11A563DE X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gao Xiang , linux-unionfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, Sarthak Kukreti , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org This patch series improves dentry revalidation in fscrypt. To recap, fscrypt (aka ext4/f2fs/ubifs encryption) encrypts both file contents and file names in individual directory trees. A single filesystem can contain many encrypted directory trees using many different encryption keys. Major users of fscrypt require the ability to delete encrypted files when their encryption key is unavailable, e.g. when the system needs to delete a removed user's home directory or free up space from a logged-out user's cache directory. Therefore fscrypt allows listing, looking up, and deleting files in encrypted directories via encoded ciphertext names, but only before the key is added. After the key is added, the ciphertext names are invalidated via ->d_revalidate() and plaintext names are shown instead. fscrypt isn't a stacked filesystem, and it's explicitly for storage encryption, not OS-level access control. Thus, whether each directory inode has its key or not is a global state, not per-process. Also, the inode keeps its key until it's evicted from the inode cache. So, plaintext names shouldn't ever get invalidated by ->d_revalidate(). This patch series makes the following improvements: - Only assign ->d_revalidate() to ciphertext filenames, thus allowing overlayfs to use an fscrypt-encrypted upperdir in some cases. (Previous discussion: https://lkml.org/lkml/2019/3/13/255) - Fix cases where plaintext filenames would wrongly be invalidated, including a real-world bug recently reported on Chromium OS. - Fix cases where ciphertext filenames would wrongly not be invalidated. - Allow rcu-walk lookups in encrypted directories with the key, which improves performance. (Previous attempt: https://patchwork.kernel.org/patch/10594133/) - Fix cases where rename() and link() could succeed on ciphertext names. Eric Biggers (5): fscrypt: clean up and improve dentry revalidation fscrypt: fix race allowing rename() and link() of ciphertext dentries fs, fscrypt: clear DCACHE_ENCRYPTED_NAME when unaliasing directory fscrypt: only set dentry_operations on ciphertext dentries fscrypt: fix race where ->lookup() marks plaintext dentry as ciphertext fs/crypto/crypto.c | 54 ++++++++++++++--------------- fs/crypto/fname.c | 1 + fs/crypto/hooks.c | 28 ++++++++++----- fs/dcache.c | 15 ++++++++ fs/ext4/ext4.h | 62 +++++++++++++++++++++++++-------- fs/ext4/namei.c | 76 ++++++++++++++++++++++++++++------------- fs/f2fs/namei.c | 17 +++++---- fs/ubifs/dir.c | 8 ++--- include/linux/dcache.h | 2 +- include/linux/fscrypt.h | 46 ++++++++++++++----------- 10 files changed, 200 insertions(+), 109 deletions(-) -- 2.21.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/