From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tudor.Ambarus@microchip.com
Cc: bmeng.cn@gmail.com, bbrezillon@kernel.org, richard@nod.at,
romain.porte@nokia.com, stable@vger.kernel.org,
marek.vasut@gmail.com, linux-mtd@lists.infradead.org,
pascal.fabreges@nokia.com, alexander.sverdlin@nokia.com,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v4] mtd: spi-nor: intel-spi: Avoid crossing 4K address boundary on read/write
Date: Wed, 20 Mar 2019 09:39:12 +0200 [thread overview]
Message-ID: <20190320073912.GP3622@lahna.fi.intel.com> (raw)
In-Reply-To: <3af53f8c-8606-c646-2e77-e6dfc8473f66@microchip.com>
On Wed, Mar 20, 2019 at 06:49:19AM +0000, Tudor.Ambarus@microchip.com wrote:
> Mika,
>
> Would you please add your Acked-by again? It's dropped in v4.
Sure.
> Looks good for me, below is my R-b.
>
> Thanks!
>
> On 03/19/2019 07:18 PM, Sverdlin, Alexander (Nokia - DE/Ulm) wrote:
> > External E-Mail
> >
> >
> > From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> >
> > It was observed that reads crossing 4K address boundary are failing.
> >
> > This limitation is mentioned in Intel documents:
> >
> > Intel(R) 9 Series Chipset Family Platform Controller Hub (PCH) Datasheet:
> >
> > "5.26.3 Flash Access
> > Program Register Access:
> > * Program Register Accesses are not allowed to cross a 4 KB boundary..."
> >
> > Enhanced Serial Peripheral Interface (eSPI)
> > Interface Base Specification (for Client and Server Platforms):
> >
> > "5.1.4 Address
> > For other memory transactions, the address may start or end at any byte
> > boundary. However, the address and payload length combination must not
> > cross the naturally aligned address boundary of the corresponding Maximum
> > Payload Size. It must not cross a 4 KB address boundary."
> >
> > Avoid this by splitting an operation crossing the boundary into two
> > operations.
> >
> > Cc: stable@vger.kernel.org
> > Reported-by: Romain Porte <romain.porte@nokia.com>
> > Tested-by: Pascal Fabreges <pascal.fabreges@nokia.com>
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-03-20 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 8:21 [PATCH v3] spi-nor: intel-spi: Avoid crossing 4K address boundary on read/write Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-13 10:56 ` Mika Westerberg
2019-03-19 16:29 ` Tudor.Ambarus
2019-03-19 16:50 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-25 0:38 ` Sasha Levin
2019-03-19 16:52 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 17:18 ` [PATCH v4] mtd: " Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-20 6:49 ` Tudor.Ambarus
2019-03-20 7:39 ` Mika Westerberg [this message]
2019-03-21 16:48 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320073912.GP3622@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexander.sverdlin@nokia.com \
--cc=bbrezillon@kernel.org \
--cc=bmeng.cn@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=pascal.fabreges@nokia.com \
--cc=richard@nod.at \
--cc=romain.porte@nokia.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).