From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C141AC43381 for ; Sun, 31 Mar 2019 11:22:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 908B32086C for ; Sun, 31 Mar 2019 11:22:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oQFtJzGi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 908B32086C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QqJRE8enBlje2pkFKyIwKNVCVsuvo96sv4HF3GjhTQs=; b=oQFtJzGi0lFKHU n5BP9KoDv63YGNtzS5x21TWerH+dbJ1bEbI8fQS8fI0uRVdsuI1PfJg8Vq5s0F6ccpBETSqAY1H/t tQfTDwp/mcR9bVBCAX8wyRqqAIcLjFEWPRaXOKtPnjnTYt9RNxnbvEv/6TQWlnlMOXZ/yclNo9bIj zEsYrqwDh+NGK7QvF7/d/WxB1BN+bAdlIxhSpRY1DtiGrI2p2+1RGYUgiqRWpLvTj2wMIveRpbvg8 lMIP5gZXwk6GkfEB6rOzzCCh8MoOufEThQOAytGuaz2EXWI2QX7A6iqCkdxgIYlDXmmN3GN0ubBgD vlzv2ZLkXbFou0VikHbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAYXP-0006UZ-2u; Sun, 31 Mar 2019 11:22:07 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAYXG-0006Mw-3h; Sun, 31 Mar 2019 11:21:59 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 69680280B8B; Sun, 31 Mar 2019 12:21:56 +0100 (BST) Date: Sun, 31 Mar 2019 13:21:53 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v2 04/36] mtd: rawnand: Use the NAND core Message-ID: <20190331132153.10962b1f@collabora.com> In-Reply-To: <20190304222841.13899-5-miquel.raynal@bootlin.com> References: <20190304222841.13899-1-miquel.raynal@bootlin.com> <20190304222841.13899-5-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_042158_281096_C1E878AA X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mason Yang , Vignesh R , Tudor Ambarus , Julien Su , Richard Weinberger , Boris Brezillon , Schrempf Frieder , Paul Cercueil , Marek Vasut , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 4 Mar 2019 23:28:09 +0100 Miquel Raynal wrote: > Before introducing the generic ECC engine abstraction, we need to be > sure that raw NAND and SPI-NAND speak the same language: let's use the > generic NAND layer with the raw NAND part (the SPI-NAND one already > uses it). Nit: I'm not sure it's useful to compile/depends on the generic NAND layer until you actually start using it. I would have selected MTD_NAND_CORE in the patch that starts using some of the functions exposed there, but that's just a tiny detail. Reviewed-by: Boris Brezillon > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > index ebb8a3da9fa5..952dc50a8634 100644 > --- a/drivers/mtd/nand/raw/Kconfig > +++ b/drivers/mtd/nand/raw/Kconfig > @@ -11,6 +11,7 @@ config MTD_NAND_ECC_SW_HAMMING_SMC > > menuconfig MTD_RAW_NAND > tristate "Raw/Parallel NAND Device Support" > + select MTD_NAND_CORE > select MTD_NAND_ECC_SW_HAMMING > help > This enables support for accessing all type of raw/parallel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/