From: Boris Brezillon <boris.brezillon@collabora.com>
To: masonccyang@mxic.com.tw
Cc: bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at,
linux-kernel@vger.kernel.org, marek.vasut@gmail.com,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
computersforpeace@gmail.com, dwmw2@infradead.org,
zhengxunli@mxic.com.tw
Subject: Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support
Date: Tue, 9 Apr 2019 11:47:01 +0200 [thread overview]
Message-ID: <20190409114701.744c2c8c@collabora.com> (raw)
In-Reply-To: <OF6C97E4DE.45261545-ON482583D7.00340468-482583D7.0034B3FE@mxic.com.tw>
On Tue, 9 Apr 2019 17:35:39 +0800
masonccyang@mxic.com.tw wrote:
> > > +
> > > +static const struct kobj_attribute sysfs_mxic_nand =
> > > + __ATTR(nand_random, S_IRUGO | S_IWUSR,
> > > + mxic_nand_rand_type_show,
> > > + mxic_nand_rand_type_store);
> >
> > No, we don't want to expose that through a sysfs file, especially since
> > changing the randomizer config means making the NAND unreadable for
> > those that have used it before the change.
> >
>
> Our on-die randomizer is still readable from user after the function
> is enabled.
You mean the memory is still readable no matter the randomizer state.
Not sure how that's possible, but okay.
> This randomizer is just like a internal memory cell
> reliability enhanced.
Why don't you enable it by default then?
> It could be enable at any time with OTP bit function and that's why
> we patch it by sys-fs.
Sorry, but that's not a good reason to expose that through sysfs.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-04-09 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 3:22 [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support Mason Yang
2019-04-09 7:04 ` Boris Brezillon
[not found] ` <OF6C97E4DE.45261545-ON482583D7.00340468-482583D7.0034B3FE@mxic.com.tw>
2019-04-09 9:47 ` Boris Brezillon [this message]
[not found] ` <OF9601E14B.A48284C4-ON482583D8.0005E3EB-482583D8.0006CC14@mxic.com.tw>
2019-04-10 7:16 ` Miquel Raynal
[not found] ` <OF37AF39D0.77A1B5F5-ON482583D8.002E12E6-482583D8.002FA5B1@mxic.com.tw>
2019-04-10 9:15 ` Miquel Raynal
2019-04-10 7:22 ` Boris Brezillon
[not found] ` <OF071D3608.9D6D2523-ON482583D9.00173F52-482583D9.0018188C@mxic.com.tw>
2019-04-11 6:53 ` Boris Brezillon
[not found] ` <OF34672B6F.AACFE22C-ON482583D9.00335814-482583D9.0033A673@mxic.com.tw>
2019-04-11 9:29 ` Boris Brezillon
[not found] ` <OF84BD5411.301E92AC-ON482583DF.000CC3CC-482583DF.000F4920@mxic.com.tw>
2019-04-17 7:08 ` Miquel Raynal
[not found] ` <OFD55A67FA.88C5BFBC-ON482583E0.0011385B-482583E0.00133C32@mxic.com.tw>
2019-04-29 9:34 ` Miquel Raynal
2019-04-17 7:11 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409114701.744c2c8c@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=juliensu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).