From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84692C10F0E for ; Tue, 9 Apr 2019 09:47:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53FF320830 for ; Tue, 9 Apr 2019 09:47:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rgqp61kO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53FF320830 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6TfipZZx8H7hRffgz2RLlPPRSsQE3OxWPRdRMMxeMlY=; b=rgqp61kO5syBaQ vdFaETkRewLbDFJVkF0m6MktHskwCZCA6wy7A4hwVxS3QQ+4kZfE0aWyzMbWjza3bTYs1+SRJ/TxQ 2KZb/5FihZGrDiLCfhHDfqipR+OnBllu9JRvalnp2pHbTZXevX+ZvfVXmnoCxwda/17wiJopX7vNf p3n0oPJlewmcrtb5cm6VKdxtDSfNgXMke7LS2zeMbSKZtj/lRKMeDd+YZZnKo0GS+5HpRDn1hNY2r 5DKiJZICxgPj/shBKq0C1foswopkCzvzJYPDlX0B3Fgj10mj3vR/88KmzVclcUAfSWPkxXP/mne4y 2436a4d9eC90nHRb7CFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDnLT-0007dI-RK; Tue, 09 Apr 2019 09:47:11 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDnLQ-0007cb-Cs for linux-mtd@lists.infradead.org; Tue, 09 Apr 2019 09:47:10 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 1DDF22820C8; Tue, 9 Apr 2019 10:47:05 +0100 (BST) Date: Tue, 9 Apr 2019 11:47:01 +0200 From: Boris Brezillon To: masonccyang@mxic.com.tw Subject: Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support Message-ID: <20190409114701.744c2c8c@collabora.com> In-Reply-To: References: <1554780172-23111-1-git-send-email-masonccyang@mxic.com.tw> <20190409090427.22de9917@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_024708_570704_2AABB82C X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbrezillon@kernel.org, juliensu@mxic.com.tw, richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com, dwmw2@infradead.org, zhengxunli@mxic.com.tw Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 9 Apr 2019 17:35:39 +0800 masonccyang@mxic.com.tw wrote: > > > + > > > +static const struct kobj_attribute sysfs_mxic_nand = > > > + __ATTR(nand_random, S_IRUGO | S_IWUSR, > > > + mxic_nand_rand_type_show, > > > + mxic_nand_rand_type_store); > > > > No, we don't want to expose that through a sysfs file, especially since > > changing the randomizer config means making the NAND unreadable for > > those that have used it before the change. > > > > Our on-die randomizer is still readable from user after the function > is enabled. You mean the memory is still readable no matter the randomizer state. Not sure how that's possible, but okay. > This randomizer is just like a internal memory cell > reliability enhanced. Why don't you enable it by default then? > It could be enable at any time with OTP bit function and that's why > we patch it by sys-fs. Sorry, but that's not a good reason to expose that through sysfs. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/