public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Stefan Agner <stefan@agner.ch>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	linux-mtd@lists.infradead.org
Subject: Re: nand_op_parser_exec_op should use longest pattern
Date: Tue, 16 Apr 2019 23:22:51 +0200	[thread overview]
Message-ID: <20190416232251.2397b4db@xps13> (raw)
In-Reply-To: <270be087c7dda47f208d194c0671f902@agner.ch>

Hi Stefan,

> >> > I have no fix for this, just wanted to let you know. It turned out that
> >> > in my case for the GPMI nand driver I probably won't need any pattern
> >> > table.  
> >>
> >> Thanks for bringing it up! Will try it out when I come around.  
> > 
> > Here is a new version of the proposed fix that compiles, at
> > least :-). Still not tested tested on a real HW though.  
> 
> Tested it here, seems to boot a rootfs from flash just fine!
> 
> The OOB reads look like this now:
> [   74.478469] nand: executing subop:
> [   74.478500] nand:     ->CMD      [0x00]
> [   74.478529] nand:     ->ADDR     [5 cyc: 00 08 c0 1d 00]
> [   74.478555] nand:     ->CMD      [0x30]
> [   74.478580] nand:     ->WAITRDY  [max 200000 ms]
> [   74.478606] nand:     ->DATA_IN  [64 B]
> 
> So the patch below seems to do what we intend.

Would you mind sending a proper patch with the below change? You can
credit Boris with a suggested-by.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      parent reply	other threads:[~2019-04-16 21:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29 13:35 nand_op_parser_exec_op should use longest pattern Sascha Hauer
2019-03-29 13:57 ` Boris Brezillon
2019-03-29 14:37 ` Stefan Agner
2019-03-30  9:21   ` Boris Brezillon
2019-04-08 20:00     ` Stefan Agner
2019-04-08 21:30       ` Miquel Raynal
2019-04-16 21:22       ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416232251.2397b4db@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox