From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE8FC04AAF for ; Tue, 21 May 2019 09:04:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22D9D21479 for ; Tue, 21 May 2019 09:04:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="agP3xKdl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22D9D21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Z+hZEwuzBIuzfpntSIJ4Xfix+se6Kl0bqJEI0ilT+s=; b=agP3xKdltekOH4 xqzuWmF+3C6vQLCotmu5hW8XM6yWWWNHKabpya4S6KKxFDAi/jYbkC+cnjCKwttw45RYU8KMwAbvC b9Voi6ECpFjaS/0DJObMAAWHKAIWLZ1KvH8PGI9WEhmbgj3MVUvJoemVPn1MfwjdHDSwKz9RhhYn4 9yozOCyMtXg/RadcutmUII45B9gNJfnp/jwsmuhji3nSC14hMxmnOpd5i4mC3NTLODYhOtmNYBUJ1 3DL+fq1vILbVb72F7eS9njSoFnxsm7t+48pCqS6556mFDQ/ItkcJ+a//mZ9qc5Wvr44xKwTuFXX3B HM2w54wYKZlNUTCu7OvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT0hQ-000892-6n; Tue, 21 May 2019 09:04:44 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT0hN-00088Z-49 for linux-mtd@lists.infradead.org; Tue, 21 May 2019 09:04:43 +0000 Received: from localhost.localdomain (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 0AC50240009; Tue, 21 May 2019 09:04:29 +0000 (UTC) From: Miquel Raynal To: Sascha Hauer , linux-mtd@lists.infradead.org Subject: Re: [PATCH v2] mtd: rawnand: initialize ntargets with maxchips Date: Tue, 21 May 2019 11:04:17 +0200 Message-Id: <20190521090417.7883-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190521084335.15026-1-s.hauer@pengutronix.de> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: fcd69b6fedcad3681f636edcc130ee1a6159a890 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_020441_315194_AE773C44 X-CRM114-Status: UNSURE ( 9.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Boris Brezillon , kernel@pengutronix.de, Miquel Raynal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 2019-05-21 at 08:43:35 UTC, Sascha Hauer wrote: > memorg->ntargets is initialized with '1'. It should be initialized with > the maxchips argument from nand_scan() instead. Otherwise multi chip > support errors out on the secondary chip selects when trying to call > nand_reset() on them: > > WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/raw/internals.h:114 > nand_reset_op+0x194/0x1c4 > > With this memorg->ntargets is initialized with the maximum number of > chip selects supported by the driver. After having detected the number > of actually connected chips memory->ntargets is updated with that > number. > > Fixes: 32813e288414 ("mtd: rawnand: Get rid of chip->numchips") > Signed-off-by: Sascha Hauer > Reviewed-by: Boris Brezillon Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/