From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9841CC04AAC for ; Thu, 23 May 2019 08:44:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5703C20881 for ; Thu, 23 May 2019 08:44:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s9jb9Vg2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ezeITHn4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5703C20881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pcz2Xxw8qT21VcqAThab8VKq6KaDxbBDIvc4YMGkgJE=; b=s9jb9Vg24LrQCQ kXQgHHnzTFHvyzY9OMqar8L1IrVNAzCUhu383g2WWmOdLZCI76hK2FBuUXIpK7hy077Hf2YcvZX2z iz8/ejl6kIjIsLYf7knvYp4WZMLiHyPSXSUEN1KpMDaZFp2/lyRQoca3HlZM0PexzVJpkIbgGfCfs n6+1hXcashHdjFRn4+CUTIfIt9G/pgSf+VB3sTYLtZ4I6F8HRBTbd6mLaaht/MyK79Ea7QN27gWVZ 1V54I++9l1GWivishRTKoxVS1PetR32eromJpbD5++25X0YJAV65HwjF2LCIdJ4MEc6oMLl1BCeHw vjQIYmVhaiQsMCpyhG4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTjLI-0007y2-KR; Thu, 23 May 2019 08:44:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTjLB-0007rB-9x; Thu, 23 May 2019 08:44:46 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E134E20881; Thu, 23 May 2019 08:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558601084; bh=VuxAbBT/lQ+VqLCO5y4r4xqAa4P5u307B+vHost8Qds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ezeITHn4Re/zKK20/gziNX7bkYNQS2gE9Hgi+c1SmSdD3ArHPD+YadwO8HExIDQLw XxI7XaN2eG+7mUNwYqzVbmyv98s7CjXbVmIM9r6cGI1YoCoyFNtKSMWD6qtLZjEYgY A2N8ZCybwnqBo30y6ropX3azbbh4+T4iupJjmF0o= Date: Thu, 23 May 2019 16:43:42 +0800 From: Shawn Guo To: Kuldeep Singh Subject: Re: [PATCH] arm64: dts: ls1012a: Add QSPI support for ls1012a Message-ID: <20190523084340.GM9261@dragon> References: <20190516114807.30817-1-kuldeep.singh@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190516114807.30817-1-kuldeep.singh@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_014445_380831_53F92C9D X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "bbrezillon@kernel.org" , Ashish Kumar , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, May 16, 2019 at 11:47:04AM +0000, Kuldeep Singh wrote: > QSPI support is added for kernel version greater than 5.0 and supports > quad mode defined by > TX-WIDTH = <4>, RX-WIDTH = <4> > > RDB/QDS has one 64MB flash from SPANSION(s25fs512s) > > Signed-off-by: Ashish Kumar > Signed-off-by: Kuldeep Singh > --- > Dependency on https://patchwork.ozlabs.org/patch/1100471/ > Dependency on https://patchwork.ozlabs.org/patch/1100472/ > > .../arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts | 15 +++++++++++++++ > .../arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 15 +++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++++++++++++++ > 5 files changed, 75 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts > index f90c040fd5e8..8826278b37bf 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts > @@ -61,6 +61,21 @@ > status = "okay"; > }; > > +&qspi { Please sort these labeling nodes alphabetically. That said, &qspi should go after &i2c0. > + status = "okay"; > + > + qflash0: flash@0 { > + compatible = "spansion,m25p80", "jedec,spi-nor"; > + #address-cells = <1>; > + #size-cells = <1>; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + reg = <0>; > + }; > +}; > + > &i2c0 { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts > index 8749634c55ee..0246e8c97628 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dts > @@ -20,6 +20,21 @@ > status = "okay"; > }; > > +&qspi { > + status = "okay"; > + > + qflash0: flash@0 { > + compatible = "spansion,m25p80", "jedec,spi-nor"; > + #address-cells = <1>; > + #size-cells = <1>; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + reg = <0>; > + }; > +}; > + > &i2c0 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts > index 2fb1cb1f7d8f..c304fa20c1c9 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts > @@ -90,6 +90,21 @@ > }; > }; > > +&qspi { > + status = "okay"; > + > + qflash0: flash@0 { > + compatible = "spansion,m25p80", "jedec,spi-nor"; > + #address-cells = <1>; > + #size-cells = <1>; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + reg = <0>; > + }; > +}; > + > &duart0 { > status = "okay"; > }; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts > index 5edb1e137a52..6017e9cfe40a 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts > @@ -38,3 +38,18 @@ > &sata { > status = "okay"; > }; > + > +&qspi { > + status = "okay"; > + > + qflash0: flash@0 { > + compatible = "spansion,m25p80", "jedec,spi-nor"; > + #address-cells = <1>; > + #size-cells = <1>; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + reg = <0>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > index ec6257a5b251..268268c6a149 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > @@ -350,6 +350,21 @@ > status = "disabled"; > }; > > + qspi: spi@1550000 { Please sort node with unit-address in that address. That said, it should go before esdhc@1560000. > + compatible = "fsl,ls1021a-qspi", "fsl,ls1012a-qspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x1550000 0x0 0x10000>, > + <0x0 0x40000000 0x0 0x10000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > + interrupts = ; > + clock-names = "qspi_en", "qspi"; > + clocks = <&clockgen 4 1>, <&clockgen 4 1>; > + big-endian; > + fsl,qspi-has-second-chip; Undocumented property? Shawn > + status = "disabled"; > + }; > + > duart0: serial@21c0500 { > compatible = "fsl,ns16550", "ns16550a"; > reg = <0x00 0x21c0500 0x0 0x100>; > -- > 2.17.1 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/