From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F31FC31E49 for ; Wed, 19 Jun 2019 13:46:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07CFA21855 for ; Wed, 19 Jun 2019 13:46:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ROTRsuCG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07CFA21855 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PATg6Opcpgp/aGJkjC9Ry/Le4NToaqdNenkIJTFNKZ4=; b=ROTRsuCG82bbCC gQqOUb1j/Qr1nA5klHJtkqMGTqyVeDuOfZtxSwWpe/rznyBbtIhodKs02wNSebFZroY5cyDszfMK2 DCnN+WsOVvqwqHQz3BXoiI7WJAWc0oOM29IrpBH0Tb3SPYb/BjM1wg1nammgqCcTeDFXIa/YSIQeQ Yxein8RvuomQMAi8ZW77nHzJfTprdH/0EFNn3ehiPiC4kY7LxyqdlNW5iQiN/Q2JgM9UHmAlMpck7 kR+y5sFQZpApIOc0FC61U24Twm+yMvVKNI7UhPzrkNvuZIVM48EnuCf1zW/82zkjLrLEQ5oo+manA X2KS7cEMj8JxJUlHJHpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdaup-0005uc-Ff; Wed, 19 Jun 2019 13:46:19 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdaum-0005u5-Sk for linux-mtd@lists.infradead.org; Wed, 19 Jun 2019 13:46:18 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 5CA0C260D87; Wed, 19 Jun 2019 14:46:14 +0100 (BST) Date: Wed, 19 Jun 2019 15:46:11 +0200 From: Boris Brezillon To: liaoweixiong Subject: Re: [PATCH] mtd: spinand: fix error read return value Message-ID: <20190619154611.3bfc007b@collabora.com> In-Reply-To: <1560950005-8868-1-git-send-email-liaoweixiong@allwinnertech.com> References: <1560950005-8868-1-git-send-email-liaoweixiong@allwinnertech.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_064617_057003_1C297B29 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , linux-kernel@vger.kernel.org, Chuanhong Guo , Marek Vasut , Frieder Schrempf , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Miquel Raynal , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , Peter Pan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi liaoweixiong, On Wed, 19 Jun 2019 21:13:24 +0800 liaoweixiong wrote: > In function spinand_mtd_read, if the last page to read occurs bitflip, > this function will return error value because veriable ret not equal to 0. Actually, that's exactly what the MTD core expects (see [1]), so you're the one introducing a regression here. Regards, Boris > > Signed-off-by: liaoweixiong > --- > drivers/mtd/nand/spi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 556bfdb..6b9388d 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from, > if (ret == -EBADMSG) { > ecc_failed = true; > mtd->ecc_stats.failed++; > - ret = 0; > } else { > mtd->ecc_stats.corrected += ret; > max_bitflips = max_t(unsigned int, max_bitflips, ret); > } > > + ret = 0; > ops->retlen += iter.req.datalen; > ops->oobretlen += iter.req.ooblen; > } [1]https://elixir.bootlin.com/linux/latest/source/drivers/mtd/mtdcore.c#L1209 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/