From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Richard Weinberger <richard@nod.at>,
LKML <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: mtd-abi: Don't use C++ comments
Date: Thu, 20 Jun 2019 13:15:49 -0700 [thread overview]
Message-ID: <20190620201549.GA65397@archlinux-epyc> (raw)
In-Reply-To: <CAKwvOdk7ZTcWEXPTBASPzk1SjOdnONawtQJkR-jU=REFSo1hVQ@mail.gmail.com>
On Thu, Jun 20, 2019 at 12:56:58PM -0700, Nick Desaulniers wrote:
> On Thu, Jun 20, 2019 at 8:55 AM Nathan Chancellor
> <natechancellor@gmail.com> wrote:
> >
> > When compiled standalone after commit b91976b7c0e3 ("kbuild:
> > compile-test UAPI headers to ensure they are self-contained"),
> > a warning about the C++ comments appears:
> >
> > In file included from usr/include/mtd/mtd-user.hdrtest.c:1:
> > In file included from ./usr/include/mtd/mtd-user.h:25:
> > ./usr/include/mtd/mtd-abi.h:116:28: warning: // comments are not
> > allowed in this language [-Wcomment]
> > #define MTD_NANDECC_OFF 0 // Switch off ECC (Not recommended)
> > ^
> > 1 warning generated.
> >
> > Replace them with standard C comments so this warning no longer occurs.
>
> Should there be a fixes by tag?
> --
> Thanks,
> ~Nick Desaulniers
Normally, I would have added one but this issue has been present since
the beginning of git history. According to Thomas Gleixner's pre-git
history tree, it would be:
Fixes: 7df80b4c8964 ("MTD core include and device code cleanup")
but since that hash doesn't exist in the normal git history, I don't
think it is worth adding. Of course, if the maintainers want to add it,
I won't object.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
Cheers,
NAthan
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-20 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 15:55 [PATCH] mtd: mtd-abi: Don't use C++ comments Nathan Chancellor
2019-06-20 19:56 ` Nick Desaulniers
2019-06-20 20:15 ` Nathan Chancellor [this message]
2019-06-20 20:29 ` Nick Desaulniers
2019-06-21 6:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620201549.GA65397@archlinux-epyc \
--to=natechancellor@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=ndesaulniers@google.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox