Re: [PATCH 2/7] vfs: flush and wait for io when setting the immutable flag via SETFLAGS

Darrick J. Wong
2019-06-24T16:37:17Z

On Mon, Jun 24, 2019 at 05:33:58PM +0200, Jan Kara wrote:
> On Fri 21-06-19 16:57:07, Darrick J. Wong wrote:
> > +/*
> > + * Flush file data before changing attributes. Caller must hold any locks
> > + * required to prevent further writes to this file until we're done setting
> > + * flags.
> > + */
> > +static inline int inode_flush_data(struct inode *inode)
> > +{
> > + inode_dio_wait(inode);
> > + return filemap_write_and_wait(inode->i_mapping);
> > +}
>
> BTW, how about calling this function inode_drain_writes() instead? The
> 'flush_data' part is more a detail of implementation of write draining than
> what we need to do to set immutable flag.

Ok, that's a much better description of what the function does.

--D

>
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR