From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE498C7618B for ; Thu, 25 Jul 2019 07:57:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE9B0217F4 for ; Thu, 25 Jul 2019 07:57:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XsOITYoQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE9B0217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zKXHvqclroZv7ClRF1VfwxE3g//IjYV0dww8px4Btc8=; b=XsOITYoQLmTdPO MvP7KqBQCWpmVd9kwEh31Y/PJOKDd4iGGOpoVOtPYZrLQ46XZqTZVu3vhRezuDLNyLe40AcOn8aVd evKArrHuZgJHt2Z2bsRImzJumapkGZKkkBOUCEKdoFBdP7ENx58lkELpUXTYX8CNKUaclBNPYGAu7 ztsmDF7v8aDVcCv+Gx87Gb421FzScndRxf4Jy+Acfmau7DXVSPPX++Of0Jtn6Q9EM+n/rh4s3wG/M /frEmU4eigYeFCx8ZDwrfKqEkR2NYls3DGbq8CjrWM4AAHIxbajwom5BHPB37fJ9X0oOkENi9IldY +Umi5hNrBzhHBRqP3/JA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqYcX-0005HX-Ei; Thu, 25 Jul 2019 07:57:01 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqYba-0004WA-SW for linux-mtd@lists.infradead.org; Thu, 25 Jul 2019 07:56:05 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 9C03E60013; Thu, 25 Jul 2019 07:55:56 +0000 (UTC) From: Miquel Raynal To: Nishka Dasgupta , stefan@agner.ch, miquel.raynal@bootlin.com, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, vigneshr@ti.com, linux-mtd@lists.infradead.org Subject: Re: [PATCH] mtd: rawnand: vf610_nfc: Add of_node_put() before goto Date: Thu, 25 Jul 2019 09:55:54 +0200 Message-Id: <20190725075554.15382-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190709170837.13315-1-nishkadg.linux@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 004147020e0363fbd3a73d3e128bcc36488d3b68 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_005603_173184_DE0958A3 X-CRM114-Status: UNSURE ( 7.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 2019-07-09 at 17:08:37 UTC, Nishka Dasgupta wrote: > Each iteration of for_each_available_child_of_node puts the previous > node, but in the case of a goto from the middle of the loop, there is no > put, thus causing a memory leak. Hence add an of_node_put before the > goto. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > Reviewed-by: Stefan Agner Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/