From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A68C76186 for ; Mon, 29 Jul 2019 19:38:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94852206DD for ; Mon, 29 Jul 2019 19:38:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H7BV45zo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QgTCz2CW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94852206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eykV0enObO4mAInu8jWvRBngFgDhrrsp+35dz7+AKhw=; b=H7BV45zoQdUeR3 KjPa4BSxtSSycPpsGN5BBlYEBSTEknRIu7N8qvdN1OozJYrSH8Ziju/ysGiX19VUXYz6tHOlp3i6I YfQ0+3bzu2djRcrK9sEzSTb6v3mN9i3LO3/ImFMe0qGnYTxdSj/FoCg5S8HPTi2DmbAUPGFrYM/+R 0VUyIZuaMs6Cvgz72+YcndyX3PWSXV2hdvsYxV978SXbMTz5Q4lGyGl0WATop3/fPcijuVy3JI8Ue 8FV0CVN0g69pbImw6AvyyR/qXD80QSFqljrpan1gO+P4dw1wVoFecAIQWRnJyjzxQACIhAU+gM3jV mKdheseCZXqGyzbFm89g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsBSu-00043H-Ki; Mon, 29 Jul 2019 19:37:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsBSq-000427-Bu for linux-mtd@lists.infradead.org; Mon, 29 Jul 2019 19:37:46 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E126206DD; Mon, 29 Jul 2019 19:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564429063; bh=35ZwmfXjVkjcTD49ueQekrtcYmxgdRwDGATcxQouXLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QgTCz2CWqZ9GLFMzgaQtbnyPki0Oxg8qrvTR97l00Gc8CQzx+zc2oXmp7EWb24DL7 lqI1c/qw8hCySTW9XZjhkJGofi5da7NFa4tbNNzKq3SlAVuvZteu0lZkG1ZnucaL4j QUyqoTdTCGY36VS+Fv9/JDNLvuGsN+DnFosM0q6c= Date: Mon, 29 Jul 2019 12:37:42 -0700 From: Eric Biggers To: "Theodore Y. Ts'o" Subject: Re: [PATCH v7 05/16] fscrypt: refactor v1 policy key setup into keysetup_legacy.c Message-ID: <20190729193740.GD169027@gmail.com> Mail-Followup-To: "Theodore Y. Ts'o" , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-api@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, Paul Crowley , Satya Tangirala References: <20190726224141.14044-1-ebiggers@kernel.org> <20190726224141.14044-6-ebiggers@kernel.org> <20190728154032.GE6088@mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190728154032.GE6088@mit.edu> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_123744_419794_37B06D02 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Satya Tangirala , linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Ted, thanks for the review! On Sun, Jul 28, 2019 at 11:40:32AM -0400, Theodore Y. Ts'o wrote: > On Fri, Jul 26, 2019 at 03:41:30PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > In preparation for introducing v2 encryption policies which will find > > and derive encryption keys differently from the current v1 encryption > > policies, refactor the v1 policy-specific key setup code from keyinfo.c > > into keysetup_legacy.c. Then rename keyinfo.c to keysetup.c. > > I'd use keysetup_v1.c, myself. We can hope that we've gotten it right > with v2 and we'll never need to do another version, but *something* is > going to come up eventually which will require a v3 keysetup , whether > it's post-quantuum cryptography or something else we can't anticipate > right now. > > For an example of the confusion that can result, one good example is > in the fs/quota subsystem, where QFMT_VFS_OLD, QFMT_VFS_V0, and > QFMT_VFS_V1 maps to quota_v1 and quota_v2 in an amusing and > non-obvious way. (Go ahead, try to guess before you go look at the > code. :-) > > Other than that, looks good. We can always move code around or rename > files in the future, so I'm not going to insist on doing it now (but > it would be my preference). > > Reviewed-by: Theodore Ts'o > Agreed, I'll call it keysetup_v1.c instead. - Eric ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/