Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Andrey Smirnov <andrew.smirnov@gmail.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	linux-mtd@lists.infradead.org, NXP Linux Team <linux-imx@nxp.com>,
	Suresh Gupta <suresh.gupta@nxp.com>,
	Chris Healy <cphealy@gmail.com>
Subject: Re: [imx][vybrid][qspi] Regression notification - vybrid vf610 QUADSPI - BK4 board
Date: Tue, 30 Jul 2019 17:14:58 +0200	[thread overview]
Message-ID: <20190730171458.7ea68db7@jawa> (raw)
In-Reply-To: <CAOMZO5BXvMByYX2ixLK+rXoT7ueb0aTmR+L-w6s6-GvFkC1Bcw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1986 bytes --]

Hi Fabio,

> Hi Lukasz,
> 
> On Mon, Jul 29, 2019 at 6:54 PM Lukasz Majewski <lukma@denx.de> wrote:
> 
> > At best it is possible to have both memories working with double SPI
> > configuration or single (QSPI0_A with quad SPI [2]).  
> 
> But according to
> Documentation/devicetree/bindings/spi/spi-fsl-qspi.txt if you use one
> chip select for bus A and one chip select for bus B, then you should
> have your dts changed like this:
> 
> diff --git a/arch/arm/boot/dts/vf610-bk4.dts
> b/arch/arm/boot/dts/vf610-bk4.dts index 3fa0cbe456db..0f3870d3b099
> 100644 --- a/arch/arm/boot/dts/vf610-bk4.dts
> +++ b/arch/arm/boot/dts/vf610-bk4.dts
> @@ -246,13 +246,13 @@
>                 reg = <0>;
>         };
> 
> -       n25q128a13_2: flash@1 {
> +       n25q128a13_2: flash@2 {
>                 compatible = "n25q128a13", "jedec,spi-nor";
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>                 spi-max-frequency = <66000000>;
>                 spi-rx-bus-width = <2>;
> -               reg = <1>;
> +               reg = <2>;
>         };
>  };

That was the exact issue it seems. I've tested the 5.2. kernel with
this test [1] and it works reliably now.

Apparently those were leftovers from some old, in-house development.

Anyway thanks for help :-)

> 
> From the dt-bindings:
> 
> "Required SPI slave node properties:
>   - reg: There are two buses (A and B) with two chip selects each.
> This encodes to which bus and CS the flash is connected:
> <0>: Bus A, CS 0
> <1>: Bus A, CS 1
> <2>: Bus B, CS 0
> <3>: Bus B, CS 1"


Note:

[1] -
https://github.com/lmajewski/tests-spi/blob/master/tests/spi/spi_nor_quadspi_test.sh

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-07-30 15:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 22:11 [imx][vybrid][qspi] Regression notification - vybrid vf610 QUADSPI - BK4 board Lukasz Majewski
2019-07-29 19:09 ` Fabio Estevam
2019-07-29 20:43   ` Lukasz Majewski
2019-07-29 21:17     ` Fabio Estevam
2019-07-29 21:54       ` Lukasz Majewski
2019-07-30  3:48         ` Fabio Estevam
2019-07-30 15:14           ` Lukasz Majewski [this message]
2019-07-30  3:07     ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730171458.7ea68db7@jawa \
    --to=lukma@denx.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=bbrezillon@kernel.org \
    --cc=cphealy@gmail.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=suresh.gupta@nxp.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox