From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230D0C43331 for ; Mon, 11 Nov 2019 09:03:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E95B62075B for ; Mon, 11 Nov 2019 09:03:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TyDi720r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E95B62075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ygm5Twzt9/zFmdRvG7k/fR13TVj3X62K79YfSO4Ndcw=; b=TyDi720rABKsOk lenuABTWYuGVX2RL44oBXlHPxJhrgqdjQvlVrqlzZBfQ3FTO6xj1/32aFO2rB7DZWfzIpZ8LxW0r4 9BuPobCLs3OdiHFJX8/tJW/lRV1XiMY72GbSh8kp55wS8urGt2Ma4ecif7cseqwcF7nU8D+KiN01g WWHoZbfCSUteeuXEDv9medfacBhvVcqSURLgvKm6oXiTsSMQciUp4uMi16MWTOd3llLIUjFxdQrG8 qhXGq1R11gR/ira2cKHgQ3k5ObIMqghyhg92AE/CJ2mPI09PG6xwgWXbvEZXMB/el+oR39WoQZXY7 3cHhatLQEyR2x+KnkCIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU5az-0000i1-Qz; Mon, 11 Nov 2019 09:02:49 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU5ax-0000hO-HH for linux-mtd@lists.infradead.org; Mon, 11 Nov 2019 09:02:48 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id BAA6228EAA4; Mon, 11 Nov 2019 09:02:44 +0000 (GMT) Date: Mon, 11 Nov 2019 10:02:41 +0100 From: Boris Brezillon To: Subject: Re: [PATCH v2 1/2] mtd: spi-nor: Make sure nor->spimem and nor->controller_ops are mutual exclusive Message-ID: <20191111100241.717a8fb9@collabora.com> In-Reply-To: <20191025142811.541-1-tudor.ambarus@microchip.com> References: <20191025123217.12790-1-tudor.ambarus@microchip.com> <20191025142811.541-1-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_010247_702847_B96F4EB1 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, dan.carpenter@oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 25 Oct 2019 14:28:34 +0000 wrote: > From: Tudor Ambarus > > Expand the spi_nor_check() to make sure that nor->spimem and > nor->controller_ops are mutual exclusive. ^mutually > > Fixes: b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c") > Reported-by: Dan Carpenter > Signed-off-by: Tudor Ambarus > --- > v2: new patch > > drivers/mtd/spi-nor/spi-nor.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index a6f9f833c862..b452d3d0de28 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2741,6 +2741,12 @@ static int spi_nor_check(struct spi_nor *nor) > return -EINVAL; > } > > + if ((nor->spimem && nor->controller_ops) || > + (!nor->spimem && !nor->controller_ops)) { > + dev_err(nor->dev, "nor->spimem and nor->controller_ops are mutual exclusive\n"); Hm, the test does more than checking that only one of nor->spimem nor->controller_ops is set, it also checks that at least one of them is provided. Maybe you should split those tests and have a different error message for each, or make the error message more generic. > + return -EINVAL; > + } > + > return 0; > } > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/