From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7360C2D0C2 for ; Fri, 3 Jan 2020 18:25:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7163F222C3 for ; Fri, 3 Jan 2020 18:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OEek0fdB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SipAHkPe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7163F222C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=spUHI4NzA70palSqmPVFWIKe8B3kF9nTgxO1THTdykI=; b=OEek0fdBT/Zz3F Bsf89aV6jj59SQHxl1zh7C5PCH60DKZpVuIjJ10Gv9IFs6ZnoXyR2oyd8ls9/r85tsP+poyT1CLQ4 m3FEXymi9EVuAtuV1i5G8uK8huztsKJZ+M6XwF0brQCxXD6lkuSPYGdRYkeaxwxN5X2/Gz067rFhE xELm8x9nW5nYbl3QePgxlC1GU/6p+je0DsTgmytxiqR22LOBN2LcZ7x4h/37uEHeYYvgmKJ/eeIJc 9rOj3s0UL8RvgYO2ckiiBaG7ss95qFhufChVv/QeWliGBUKtFqgIyN6tpxv9SUNuBx8wF3hrSr+PT aDtTlyDOu87kiil0nP/g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1inRdR-0004Wu-42; Fri, 03 Jan 2020 18:25:21 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1inRdI-00048S-7C; Fri, 03 Jan 2020 18:25:14 +0000 Received: by mail-pl1-x641.google.com with SMTP id c13so19330720pls.0; Fri, 03 Jan 2020 10:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qW83qsxpwf2/UZcSK+rVXwz9u16IUPoBDgWO6FkrDOc=; b=SipAHkPek4LSECCncIfZjoX69+G+fklKFs+PgfunA7KEM8mTXKyE8b38CLrrMCLm6I RAhBytnJED1/yanNGg7MAKRr6/o+QaZBaPQeltRDJq4RfPB1MzihPr1BYLktqdAFe/6f 1uM0QGWsDXTkngXx0ZyBDn0WNvqTQSxAFabRgZAp6ch4J3oVCcONiIn30pGSOjJf3blB ny8TX9HbNMLXSnZCtmX6K4KdMT2Nh/JY3NfeWxV5k2mGwhFjHCcITTLi/mrS0hrBZOEb +SCCgHGMujpor6+kk9E0zQTlPlyxzmSUn4efiUStGOiMEmi3QreatlGEUUQq4xbRwKyG 9ADw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qW83qsxpwf2/UZcSK+rVXwz9u16IUPoBDgWO6FkrDOc=; b=a+TIJ5VoOHYmSEHBR20Kqh0LrGXnKNfWHPuS98+DSfAnNoT0gdEzPCj4im0BwAl2SL ta/8PuYcQrY6ZXarPYhoFl//5hbas4ecsHRlfFmhN50J3U6GXOTzbY8DZyFAHRlDPIqz eG7/Ls6WHyF0D650s8wlMdmuV/ZDFNop5IfUunCRz7uRBd7zZn9hgwAaM8kKDCqu7veG ih16oER6kIuy6nEkfHFQf5n4D97vf+B9M/dHzFp9qfTOT/bV6iqlH0ehQ+5O5RZZpkh1 ZzyV91suPRCI/3J7ei+gzSwCscqoNhMSd6oKoBQ72SopNjH4104lDgrdl40eCAQru8kg pYiA== X-Gm-Message-State: APjAAAUJFsM28qkfuS9HjpxIbJFSvpFfCB/bQkyS7BWA6TdC7H0IAS5/ 9q81rkJIC0t9eXLLfxmnj1s= X-Google-Smtp-Source: APXvYqwsZQKqtyEyj2LOAt7A+rTqD0fBPwGrTf/wve3kKW4OAwb5MIup6B8yu2JOby9GpsDWJZnu0Q== X-Received: by 2002:a17:902:7c0f:: with SMTP id x15mr53728214pll.267.1578075911549; Fri, 03 Jan 2020 10:25:11 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id r8sm15054771pjo.22.2020.01.03.10.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2020 10:25:11 -0800 (PST) Date: Fri, 3 Jan 2020 10:25:09 -0800 From: Dmitry Torokhov To: Alexandre Belloni Subject: Re: [PATCH] mtd: rawnand: atmel: switch to using devm_fwnode_gpiod_get() Message-ID: <20200103182509.GF8314@dtor-ws> References: <20200103012238.GA3648@dtor-ws> <20200103090704.GG3040@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200103090704.GG3040@piout.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200103_102512_291573_252BA113 X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Boris Brezillon , Nicolas Ferre , linux-kernel@vger.kernel.org, Ludovic Desroches , linux-mtd@lists.infradead.org, Miquel Raynal , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Alexandre, On Fri, Jan 03, 2020 at 10:07:04AM +0100, Alexandre Belloni wrote: > Hi, > > On 02/01/2020 17:22:38-0800, Dmitry Torokhov wrote: > > devm_fwnode_get_index_gpiod_from_child() is going away as the name is > > too unwieldy, let's switch to using the new devm_fwnode_gpiod_get(). > > > > Signed-off-by: Dmitry Torokhov > > --- > > drivers/mtd/nand/raw/atmel/nand-controller.c | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > > index 8d6be90a6fe8a..849bd5f16492d 100644 > > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > > @@ -1578,9 +1578,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > > > > nand->numcs = numcs; > > > > - gpio = devm_fwnode_get_index_gpiod_from_child(nc->dev, "det", 0, > > - &np->fwnode, GPIOD_IN, > > - "nand-det"); > > + gpio = devm_fwnode_gpiod_get(nc->dev, of_fwnode_hanlde(np), > > Shouldn't that be of_fwnode_handle(np)? :( You are right. Apparently I did not actually enable the driver when trying to compile this. I'll update and repost this shortly. -- Dmitry ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/