From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E96C282DD for ; Wed, 8 Jan 2020 16:57:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 946A72072A for ; Wed, 8 Jan 2020 16:57:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uh3nvfxF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 946A72072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+6R2L742TxK4c1VdC6vlT6bM1zZsmqW6msJTZIYFCUE=; b=Uh3nvfxFFDz6Mm 14zWzdkOhXkflT5ZyM6RabMitt3WXLya11bpPHe3/LPz0UjLdqJSbMY79oWTgsrX4DJRPUjGgStVT GVR6fvz9RmS6o6xBaJv00151ZZoqSRpC4tSFI3vpBXV3ZFoUWxuHgjR/i52z89Fj1Tba+UsirBGf+ eyqbaceKuQc07MD6vT/SHF+X7tILizoYvquJ+EUYhArA1YZmqvFybLO4FqPY+sB7JQCjATkO97tgP zRMcEtzOQj0fScZ3MjMOubopIZhFzkAJnbgu5yZWXaKe+SbH70CAK0fi+kcE9JP/pL7Jl1+bE2yuX yU3LDGcRwxU02UxARzyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipEe2-0008I8-DS; Wed, 08 Jan 2020 16:57:22 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipEdq-000890-Pg; Wed, 08 Jan 2020 16:57:10 +0000 Date: Wed, 8 Jan 2020 08:57:10 -0800 From: Christoph Hellwig To: Andreas Gruenbacher Subject: Re: [PATCH v4] fs: Fix page_mkwrite off-by-one errors Message-ID: <20200108165710.GA18523@infradead.org> References: <20200108131528.4279-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200108131528.4279-1-agruenba@redhat.com> X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , Chao Yu , Adrian Hunter , Chris Mason , Andreas Dilger , Sage Weil , "Darrick J. Wong" , Richard Weinberger , YueHaibing , Christoph Hellwig , Ilya Dryomov , linux-ext4@vger.kernel.org, Arnd Bergmann , Chao Yu , Josef Bacik , Alexander Viro , David Sterba , Jaegeuk Kim , ceph-devel@vger.kernel.org, Theodore Ts'o , Artem Bityutskiy , Jeff Layton , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, Linus Torvalds , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org I don't want to be the party pooper, but shouldn't this be a series with one patch to add the helper, and then once for each fs / piece of common code switched over? On Wed, Jan 08, 2020 at 02:15:28PM +0100, Andreas Gruenbacher wrote: > Hi Darrick, > > here's an updated version with the latest feedback incorporated. Hope > you find that useful. > > As far as the f2fs merge conflict goes, I've been told by Linus not to > resolve those kinds of conflicts but to point them out when sending the > merge request. So this shouldn't be a big deal. Also this isn't really the proper way to write a commit message. This text would go into the cover letter if it was a series.. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/