From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
richard@nod.at, jdike@addtoit.com, linux-um@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
davidgow@google.com, anton.ivanov@cambridgegreys.com,
Piotr Sroka <piotrs@cadence.com>
Subject: Re: [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency
Date: Thu, 9 Jan 2020 16:23:03 +0100 [thread overview]
Message-ID: <20200109162303.35f4f0a3@xps13> (raw)
In-Reply-To: <20191211192742.95699-3-brendanhiggins@google.com>
Hi Brendan,
Brendan Higgins <brendanhiggins@google.com> wrote on Wed, 11 Dec 2019
11:27:37 -0800:
> Currently CONFIG_MTD_NAND_CADENCE implicitly depends on
> CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> the following build error:
>
> ld: drivers/mtd/nand/raw/cadence-nand-controller.o: in function `cadence_nand_dt_probe.cold.31':
> drivers/mtd/nand/raw/cadence-nand-controller.c:2969: undefined reference to `devm_platform_ioremap_resource'
> ld: drivers/mtd/nand/raw/cadence-nand-controller.c:2977: undefined reference to `devm_ioremap_resource'
>
> Fix the build error by adding the unspecified dependency.
>
> Reported-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
Sorry for the delay.
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-09 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: add unspecified HAS_IOMEM dependency Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal [this message]
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109162303.35f4f0a3@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bbrezillon@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=piotrs@cadence.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox