From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com>
Cc: linux-mtd@lists.infradead.org, vigneshr@ti.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: Add comment about Kioxia ID
Date: Wed, 5 Feb 2020 11:01:01 +0100 [thread overview]
Message-ID: <20200205110101.3d4e2e6a@xps13> (raw)
In-Reply-To: <73dae14b-5bf0-b909-3229-aab3ed232669@kioxia.com>
Hi Yoshio,
Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com> wrote on Tue, 4 Feb 2020
19:30:04 +0900:
> Dear Miquèl,
>
>
> On 2020/02/04 17:52, Miquel Raynal wrote:
> > Hi Yoshio,
> >
> > Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com> wrote on Tue, 4 Feb
> > 2020 11:26:03 +0900:
> >
> >> Add a comment above NAND_MFR_TOSHIBA and SPINAND_MFR_TOSHIBA definitions
> >> that Toshiba and Kioxia ID are the same.
> >>
> >> Signed-off-by: Yoshio Furuyama <ytc-mb-yfuruyama7@kioxia.com>
> >> ---
> >> drivers/mtd/nand/raw/internals.h | 1 +
> >> drivers/mtd/nand/spi/toshiba.c | 1 +
> >> 2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h
> >> index cba6fe7..2918376b 100644
> >> --- a/drivers/mtd/nand/raw/internals.h
> >> +++ b/drivers/mtd/nand/raw/internals.h
> >> @@ -30,6 +30,7 @@
> >> #define NAND_MFR_SAMSUNG 0xec
> >> #define NAND_MFR_SANDISK 0x45
> >> #define NAND_MFR_STMICRO 0x20
> >> +/* Toshiba and Kioxia ID are the same. */
> >> #define NAND_MFR_TOSHIBA 0x98
> >> #define NAND_MFR_WINBOND 0xef
> >> >> diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c
> >> index 0db5ee4..a92ecc8 100644
> >> --- a/drivers/mtd/nand/spi/toshiba.c
> >> +++ b/drivers/mtd/nand/spi/toshiba.c
> >> @@ -10,6 +10,7 @@
> >> #include <linux/kernel.h>
> >> #include <linux/mtd/spinand.h>
> >> >> +/* Toshiba and Kioxia ID are the same. */
> >> #define SPINAND_MFR_TOSHIBA 0x98
> >> #define TOSH_STATUS_ECC_HAS_BITFLIPS_T (3 << 4)
> >> >
> > "Are the same" is not very descriptive, what about "Kioxia is the new
> > name of Toshiba"?
>
>
> That's a good idea.
>
> Actually ,
>
> Is was changed a company name from Toshiba memory Co to Kioxia Co. Since became independent from Toshiba group.
>
> I will update the comment as "Kioxia is new name of Toshiba memory"
Well, in this case I would even recommend something more meaningful:
"Since its independence from Toshiba Group, Toshiba memory Co has become Kioxia Co"
Also, please update the version of your patch to "v3" in the title
"[PATCH v3] ...", this can be done automatically when formatting your
patch with git format-patch with the -v 3 option.
Also the prefix should be "mtd: spinand: toshiba:"
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-02-05 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 2:26 [PATCH] mtd: nand: Add comment about Kioxia ID Yoshio Furuyama
2020-02-04 8:52 ` Miquel Raynal
2020-02-04 10:30 ` Yoshio Furuyama
2020-02-05 10:01 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205110101.3d4e2e6a@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vigneshr@ti.com \
--cc=ytc-mb-yfuruyama7@kioxia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).