From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171B2C54EEB for ; Tue, 24 Mar 2020 22:05:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD38D2077D for ; Tue, 24 Mar 2020 22:05:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uJvvh4UG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD38D2077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tjMSU15/j9ERm7buAYX4bK0ciuRcYmSWxPYu34OkSeM=; b=uJvvh4UGScQjui KX4pQzNdMBekRrW8pNGGQ3qbrnVyJdsldCijKU+eJmLUtGVBYbSX+LK3Nvi+a2JIvsPuToygAKM3f 59nn3hHvUoSYv5i6us/Pw90LUv/1lfdGXlZpvIlb0pibFNtGwsi246o4522H2t8E+2pW4CZr2xRbl kGiDoT7XfjawVlpdO3QtLEZN60vUXnW7NlnKtzQWwfK9rxmCQynCmRk6PXJ/BAkIV1yz3cJoZGZD2 9dD3wUj175zZeprfM9dyJd2/AxELKXenLwWIEo+3F5a28+4YMb5sznvR9nSu5v9Zj9Pe88TT9U6m+ +IxRhQQFh2/blovi6V4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGrg5-0005yN-EJ; Tue, 24 Mar 2020 22:05:41 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGrg2-0005xb-I5 for linux-mtd@lists.infradead.org; Tue, 24 Mar 2020 22:05:40 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id C461E20004; Tue, 24 Mar 2020 22:05:34 +0000 (UTC) From: Miquel Raynal To: Xiaoming Ni , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success Date: Tue, 24 Mar 2020 23:05:33 +0100 Message-Id: <20200324220533.15273-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <1584674111-101462-1-git-send-email-nixiaoming@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 4e4a9a828af29785fad12ecc11583769e1282024 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200324_150538_732981_368A7070 X-CRM114-Status: UNSURE ( 5.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangweimin12@huawei.com, linux-mtd@lists.infradead.org, wangle6@huawei.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 2020-03-20 at 03:15:11 UTC, Xiaoming Ni wrote: > mtdblock_flush() > -->write_cached_data() > --->erase_write() > mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed > > Because mtdblock_flush() always returns 0, > even if write_cached_data() fails and data is not written to the device, > syscall_write() still returns success > > Signed-off-by: Xiaoming Ni Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/