From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com>
Cc: cheol.yong.kim@intel.com, devicetree@vger.kernel.org,
andriy.shevchenko@intel.com, anders.roxell@linaro.org,
vigneshr@ti.com, arnd@arndb.de, richard@nod.at,
qi-ming.wu@intel.com, brendanhiggins@google.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
tglx@linutronix.de, masonccyang@mxic.com.tw, piotrs@cadence.com
Subject: Re: [PATCH v1 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Tue, 14 Apr 2020 09:21:32 +0200 [thread overview]
Message-ID: <20200414092132.525053f1@collabora.com> (raw)
In-Reply-To: <20200414022433.36622-3-vadivel.muruganx.ramuthevar@linux.intel.com>
Hello Ramuthevar,
On Tue, 14 Apr 2020 10:24:33 +0800
"Ramuthevar,Vadivel MuruganX"
<vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
> + lgm_host->chip.legacy.read_byte = lgm_read_byte;
> + lgm_host->chip.legacy.read_buf = lgm_read_buf;
> + lgm_host->chip.legacy.write_buf = lgm_write_buf;
> + lgm_host->chip.legacy.select_chip = lgm_select_chip;
> + lgm_host->chip.legacy.dev_ready = lgm_dev_ready;
> + lgm_host->chip.legacy.cmd_ctrl = lgm_cmd_ctrl;
> + lgm_host->chip.legacy.chip_delay = 30;
> + lgm_host->chip.legacy.dummy_controller.ops = &lgm_nand_controller_ops;
> +
Seriously, what's not clear in [1]? Okay, let's say you overlooked this
comment, isn't the name of the field explicit enough? We received a
few other drivers implementing the legacy interface in the last few
months so maybe there's something to improve on our end (update the
doc, move legacy drivers to a legacy sub-dir?).
Back to more constructive comment now: please implement ->exec_op() to
replace those legacy hooks.
Regards,
Boris
[1]https://elixir.bootlin.com/linux/v5.7-rc1/source/include/linux/mtd/rawnand.h#L987
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-14 7:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 2:24 [PATCH v1 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar, Vadivel MuruganX
2020-04-14 2:24 ` [PATCH v1 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Ramuthevar, Vadivel MuruganX
2020-04-14 7:04 ` Boris Brezillon
2020-04-15 1:51 ` Ramuthevar, Vadivel MuruganX
2020-04-14 2:24 ` [PATCH v1 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar, Vadivel MuruganX
2020-04-14 7:21 ` Boris Brezillon [this message]
2020-04-15 6:01 ` Ramuthevar, Vadivel MuruganX
2020-04-15 22:05 ` Martin Blumenstingl
2020-04-16 9:35 ` Ramuthevar, Vadivel MuruganX
2020-04-16 9:38 ` Boris Brezillon
2020-04-16 9:45 ` Ramuthevar, Vadivel MuruganX
2020-04-16 10:26 ` Boris Brezillon
2020-04-16 10:40 ` Ramuthevar, Vadivel MuruganX
2020-04-16 11:17 ` Boris Brezillon
2020-04-16 11:32 ` Andy Shevchenko
2020-04-17 5:10 ` Ramuthevar, Vadivel MuruganX
[not found] ` <de9f50b8-9215-d294-9914-e49701552185@linux.intel.com>
2020-04-16 11:57 ` Boris Brezillon
2020-04-16 12:26 ` Andy Shevchenko
2020-04-16 12:40 ` Boris Brezillon
2020-04-16 13:20 ` Arnd Bergmann
2020-04-16 13:51 ` John Crispin
2020-04-20 1:09 ` Ramuthevar, Vadivel MuruganX
2020-04-16 18:08 ` Martin Blumenstingl
2020-04-17 5:21 ` Ramuthevar, Vadivel MuruganX
2020-04-17 7:02 ` Boris Brezillon
2020-04-17 7:53 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414092132.525053f1@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=brendanhiggins@google.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=piotrs@cadence.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).