From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A97C2BB55 for ; Thu, 16 Apr 2020 12:46:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C71ED208E4 for ; Thu, 16 Apr 2020 12:46:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KUCxMhEb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C71ED208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j6fEYV52Eoek40aQ402MzzRjy7Zc9GE5H3HKE2J/bzo=; b=KUCxMhEbBg6m4r iuefmzNhWCWICkUZ1lhV2NZ9Zftl9IBo6l4iQHwwBYFvY34TbcYY3VQlK85Qq4VcApTRJUKlsZzA6 FDYY3H9vSdoL6E+KZ1Gh32FaKydRKrIimu1kLtTMqk74oicYCN5e9PO0LFz0MG1vqHPNaLjCMDq5a ZUCNxy/HeeYyi0kOFSoazF1JIBNqSxETtTBIE0lcpwZs+Ka99EDx7l+k8I53YZuvUf8yvUqX1wT9E iLB6ZurBR0XBqHVPa+a/9e1t4bY8kaIo1059o4iiji6p1CfeSpLk+W0Xc8i6VPJrEw9r/TZQDi78Q aiejgrPXtTB0vZM4JhCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP3uL-0004gW-Sc; Thu, 16 Apr 2020 12:46:17 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP3uH-0001QC-SB; Thu, 16 Apr 2020 12:46:15 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 924AA80487; Thu, 16 Apr 2020 14:44:00 +0200 (CEST) Date: Thu, 16 Apr 2020 14:43:59 +0200 From: Sam Ravnborg To: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting Message-ID: <20200416124359.GB5785@ravnborg.org> References: <20200416005549.9683-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200416005549.9683-1-robh@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=xJWM5Xtqm7-vkBAKM1YA:9 a=bxeknKLoBf6BnO7k:21 a=StjP_oZuoJ7ca4eH:21 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_054614_277690_CB7108E0 X-CRM114-Status: GOOD ( 21.61 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Ulf Hansson , Heiko Stuebner , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, Alexandre Belloni , dri-devel@lists.freedesktop.org, Bjorn Andersson , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Pavel Machek , linux-riscv@lists.infradead.org, Fabio Estevam , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Florian Fainelli , Lee Jones , Daniel Lezcano , Krzysztof Kozlowski , Bartosz Golaszewski , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Guenter Roeck , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Alexandre Torgue , alsa-devel@alsa-project.org, Maxime Ripard , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Jacek Anaszewski , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Stephen Boyd , Greg Kroah-Hartman , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , linux-spi@vger.kernel.org, Vinod Koul , netdev@vger.kernel.org, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Rob. On Wed, Apr 15, 2020 at 07:55:48PM -0500, Rob Herring wrote: > Fix various inconsistencies in schema indentation. Most of these are > list indentation which should be 2 spaces more than the start of the > enclosing keyword. This doesn't matter functionally, but affects running > scripts which do transforms on the schema files. Are there any plans to improve the tooling so we get warnigns for this? Otherwise I am afraid we will see a lot of patches that gets this wrong. As a follow-up patch it would be good if example-schema.yaml could gain some comments about the correct indentions. Some comments in the following. > diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml > index 49e0362ddc11..b388c5aa7984 100644 > --- a/Documentation/devicetree/bindings/arm/altera.yaml > +++ b/Documentation/devicetree/bindings/arm/altera.yaml > @@ -13,8 +13,8 @@ properties: > compatible: > items: > - enum: > - - altr,socfpga-cyclone5 > - - altr,socfpga-arria5 > - - altr,socfpga-arria10 > + - altr,socfpga-cyclone5 > + - altr,socfpga-arria5 > + - altr,socfpga-arria10 > - const: altr,socfpga So here "- enum" do not need the extra indent. Is it because this is not a list? > ... > diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml > index 66213bd95e6e..6cc74523ebfd 100644 > --- a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml > +++ b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml > @@ -25,7 +25,7 @@ select: > > properties: > compatible: > - items: > + items: > - const: amlogic,meson-gx-ao-secure > - const: syscon This is something I had expected the tooling to notice. I had expected the two "- const" to be indented with 4 spaces, not two. So there is something I do not understand. > diff --git a/Documentation/devicetree/bindings/arm/nxp/lpc32xx.yaml b/Documentation/devicetree/bindings/arm/nxp/lpc32xx.yaml > index 07f39d3eee7e..f7f024910e71 100644 > --- a/Documentation/devicetree/bindings/arm/nxp/lpc32xx.yaml > +++ b/Documentation/devicetree/bindings/arm/nxp/lpc32xx.yaml > @@ -17,9 +17,8 @@ properties: > - nxp,lpc3230 > - nxp,lpc3240 > - items: > - - enum: > - - ea,ea3250 > - - phytec,phy3250 > - - const: nxp,lpc3250 > - > + - enum: > + - ea,ea3250 > + - phytec,phy3250 > + - const: nxp,lpc3250 > ... And here "- enum" receive extra indent. I trust you know what you are doing - but I do not get it. Some pointers or examples for the correct indention would be great. I cannot review this patch as long as I do not know the rules. My request to update example-schema.yaml was one way to teach me. (Some people will say that is difficult/impossible to teach me, but thats another story:-) ). Sam ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/