From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F97C54FC9 for ; Tue, 21 Apr 2020 16:48:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84FD1206A1 for ; Tue, 21 Apr 2020 16:48:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fMzpm4bM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84FD1206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6TJb6FfmIMUhsA+WJvDTnyW6a7o7pIqZ5Y3TRkixiTI=; b=fMzpm4bMedzdXC vJKiwLmy7wNWL0yE85okjuWfBwrObSvxujPuI2sHxbMfIWMwm1DepKlE96q16Lh52/ONcrvTwOL6D 5U8D56YbhS4OdR4flXDbrbyUicxCodMFuqjjjyBxQ2iofYSsdm4Bcn3EYcTZx9y+qOHb5x+Ihb/ql VXHYdaQBV1DryCZGQU9kbtPBIkJI84toYDbg8He5i7JmmanRyzLluxfxaspGmeMGu9i2hChxlUbpx Qh4OcytLmkFYO5J8wZxoOXrkQoVon2dfUc6HD9HYlJd7BZ4EEruHZOn+Fs0IoKeGedV3KB/YumN18 oSfFejKFtAKiYjaynJvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQw4C-0005Sk-RS; Tue, 21 Apr 2020 16:48:12 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQw2q-00041Y-GQ for linux-mtd@lists.infradead.org; Tue, 21 Apr 2020 16:46:49 +0000 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 2DE6B20004; Tue, 21 Apr 2020 16:46:46 +0000 (UTC) From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Subject: [PATCH 6/8] mtd: rawnand: onfi: Simplify the NAND operations during detection Date: Tue, 21 Apr 2020 18:46:35 +0200 Message-Id: <20200421164637.8086-7-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200421164637.8086-1-miquel.raynal@bootlin.com> References: <20200421164637.8086-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_094648_697745_2B63A2C8 X-CRM114-Status: GOOD ( 10.79 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Boris Brezillon , Naga Sureshkumar Relli , Thomas Petazzoni , Miquel Raynal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org There is no need for separate parameter page reads, the delay penalty is negligible so let's do read the three copies in one go. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/nand_onfi.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_onfi.c b/drivers/mtd/nand/raw/nand_onfi.c index d6124180b47b..b76772666b82 100644 --- a/drivers/mtd/nand/raw/nand_onfi.c +++ b/drivers/mtd/nand/raw/nand_onfi.c @@ -160,19 +160,13 @@ int nand_onfi_detect(struct nand_chip *chip) if (!pbuf) return -ENOMEM; - ret = nand_read_param_page_op(chip, 0, NULL, 0); + ret = nand_read_param_page_op(chip, 0, pbuf, 3 * sizeof(*pbuf)); if (ret) { ret = 0; goto free_onfi_param_page; } for (i = 0; i < 3; i++) { - ret = nand_read_data_op(chip, &pbuf[i], sizeof(*pbuf), true); - if (ret) { - ret = 0; - goto free_onfi_param_page; - } - crc = onfi_crc16(ONFI_CRC_BASE, (u8 *)&pbuf[i], 254); if (crc == le16_to_cpu(pbuf[i].crc)) { p = &pbuf[i]; -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/