From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Michal Simek <monstr@monstr.eu>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Naga Sureshkumar Relli <nagasure@xilinx.com>
Subject: Re: [PATCH 1/8] mtd: rawnand: timings: Add mode information to the timings structure
Date: Wed, 22 Apr 2020 08:36:52 +0200 [thread overview]
Message-ID: <20200422083652.6e643a4b@collabora.com> (raw)
In-Reply-To: <20200421164637.8086-2-miquel.raynal@bootlin.com>
On Tue, 21 Apr 2020 18:46:30 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Convert the timings union into a structure containing the mode and the
> actual values. The values are still a union in prevision of the
> addition of the NVDDR modes.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Two nits below.
> ---
> drivers/mtd/nand/raw/nand_timings.c | 6 ++++++
> include/linux/mtd/rawnand.h | 10 +++++++---
> 2 files changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c
> index f64b06a71dfa..0061cbaf931d 100644
> --- a/drivers/mtd/nand/raw/nand_timings.c
> +++ b/drivers/mtd/nand/raw/nand_timings.c
> @@ -16,6 +16,7 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> /* Mode 0 */
> {
> .type = NAND_SDR_IFACE,
> + .timings.mode = 0,
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> @@ -58,6 +59,7 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> /* Mode 1 */
> {
> .type = NAND_SDR_IFACE,
> + .timings.mode = 1,
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> @@ -100,6 +102,7 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> /* Mode 2 */
> {
> .type = NAND_SDR_IFACE,
> + .timings.mode = 2,
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> @@ -142,6 +145,7 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> /* Mode 3 */
> {
> .type = NAND_SDR_IFACE,
> + .timings.mode = 3,
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> @@ -184,6 +188,7 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> /* Mode 4 */
> {
> .type = NAND_SDR_IFACE,
> + .timings.mode = 4,
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> @@ -226,6 +231,7 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
> /* Mode 5 */
> {
> .type = NAND_SDR_IFACE,
> + .timings.mode = 5,
> .timings.sdr = {
> .tCCS_min = 500000,
> .tR_max = 200000000,
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 1e76196f9829..d91f914d2e9e 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -491,13 +491,17 @@ enum nand_data_interface_type {
> /**
> * struct nand_data_interface - NAND interface timing
> * @type: type of the timing
> - * @timings: The timing, type according to @type
> + * @timings: The timing
^timing information
> + * @timings.mode: Timing mode as referred in the specification
^ as defined?
> * @timings.sdr: Use it when @type is %NAND_SDR_IFACE.
> */
> struct nand_data_interface {
> enum nand_data_interface_type type;
> - union {
> - struct nand_sdr_timings sdr;
> + struct nand_timings {
> + unsigned int mode;
> + union {
> + struct nand_sdr_timings sdr;
> + };
> } timings;
> };
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-22 6:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 16:46 [PATCH 0/8] Misc timing changes Miquel Raynal
2020-04-21 16:46 ` [PATCH 1/8] mtd: rawnand: timings: Add mode information to the timings structure Miquel Raynal
2020-04-22 6:36 ` Boris Brezillon [this message]
2020-04-21 16:46 ` [PATCH 2/8] mtd: rawnand: timings: Fix default tR_max and tCCS_min timings Miquel Raynal
2020-04-22 6:47 ` Boris Brezillon
2020-04-21 16:46 ` [PATCH 3/8] mtd: rawnand: onfi: Fix redundancy detection check Miquel Raynal
2020-04-22 6:49 ` Boris Brezillon
2020-04-21 16:46 ` [PATCH 4/8] mtd: rawnand: onfi: Use an intermediate variable to decomplefixy conditions Miquel Raynal
2020-04-22 6:51 ` Boris Brezillon
2020-04-21 16:46 ` [PATCH 5/8] mtd: rawnand: onfi: Avoid doing a copy of the parameter page Miquel Raynal
2020-04-22 6:54 ` Boris Brezillon
2020-04-21 16:46 ` [PATCH 6/8] mtd: rawnand: onfi: Simplify the NAND operations during detection Miquel Raynal
2020-04-22 7:00 ` Boris Brezillon
2020-04-22 7:25 ` Miquel Raynal
2020-04-21 16:46 ` [PATCH 7/8] mtd: rawnand: jedec: Use an intermediate variable to decomplefixy conditions Miquel Raynal
2020-04-22 7:02 ` Boris Brezillon
2020-04-22 8:49 ` Sergei Shtylyov
2020-04-22 9:33 ` Miquel Raynal
2020-04-21 16:46 ` [PATCH 8/8] mtd: rawnand: jedec: Simplify the NAND operations during detection Miquel Raynal
2020-04-22 7:05 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422083652.6e643a4b@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=monstr@monstr.eu \
--cc=nagasure@xilinx.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).