From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03DCDC55181 for ; Wed, 22 Apr 2020 06:55:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A69D3206D9 for ; Wed, 22 Apr 2020 06:55:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dw5sBnvF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A69D3206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m5U/zDw/QNhFPrhbZM0C1qGwcgI8mTcEpKC/dtI0TL0=; b=dw5sBnvFsFS7Ca XmhgPwdY3hp6lY/rzfrpGQ79odGlW8JiPR6UJWmZ1Ah3crtw6s6bhA4yctUdpAMl4fNMEcw0Yhdki Kv4+gAvajTDheBu98W2XJjk5SjqAL46Tpvkyjgc/3HRIb2WYPKyMb3i3fRbaoenyrVM4b/vEt+8j2 fy79L5JQcRlhSaBD2gwpqbSNgz/Zb34GlYTYMqImTVfl0t0qx1dqL4//RzTJJQNlnRtfa7cPeAbnm 9km1Zh5DWgOk0qof0LBPjiJ/ygMSFrVIQgeU04+NfH3O4lVu8Q4HQ3lwxuw59lwk4SVCANWhetlyE 1vCzgnZ5VQj6Z8I87KxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jR9Hd-0004xY-LV; Wed, 22 Apr 2020 06:54:57 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jR9HZ-0004vZ-Qy for linux-mtd@lists.infradead.org; Wed, 22 Apr 2020 06:54:55 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7023D2A1920; Wed, 22 Apr 2020 07:54:52 +0100 (BST) Date: Wed, 22 Apr 2020 08:54:48 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH 5/8] mtd: rawnand: onfi: Avoid doing a copy of the parameter page Message-ID: <20200422085448.7e2fb95f@collabora.com> In-Reply-To: <20200421164637.8086-6-miquel.raynal@bootlin.com> References: <20200421164637.8086-1-miquel.raynal@bootlin.com> <20200421164637.8086-6-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_235454_316229_FAB24F2D X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 21 Apr 2020 18:46:34 +0200 Miquel Raynal wrote: > There is not need for copying the parameter page, playing with ^no > pointers works the same. ^does the trick? > > There is not functional change. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_onfi.c | 29 ++++++++++++++--------------- > 1 file changed, 14 insertions(+), 15 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_onfi.c b/drivers/mtd/nand/raw/nand_onfi.c > index 7d9a3130443a..d6124180b47b 100644 > --- a/drivers/mtd/nand/raw/nand_onfi.c > +++ b/drivers/mtd/nand/raw/nand_onfi.c > @@ -141,7 +141,7 @@ int nand_onfi_detect(struct nand_chip *chip) > { > struct mtd_info *mtd = nand_to_mtd(chip); > struct nand_memory_organization *memorg; > - struct nand_onfi_params *p; > + struct nand_onfi_params *p = NULL, *pbuf; > struct onfi_params *onfi; > int onfi_version = 0; > char id[4]; > @@ -156,8 +156,8 @@ int nand_onfi_detect(struct nand_chip *chip) > return 0; > > /* ONFI chip: allocate a buffer to hold its parameter page */ > - p = kzalloc((sizeof(*p) * 3), GFP_KERNEL); > - if (!p) > + pbuf = kzalloc((sizeof(*pbuf) * 3), GFP_KERNEL); > + if (!pbuf) > return -ENOMEM; > > ret = nand_read_param_page_op(chip, 0, NULL, 0); > @@ -167,32 +167,31 @@ int nand_onfi_detect(struct nand_chip *chip) > } > > for (i = 0; i < 3; i++) { > - ret = nand_read_data_op(chip, &p[i], sizeof(*p), true); > + ret = nand_read_data_op(chip, &pbuf[i], sizeof(*pbuf), true); > if (ret) { > ret = 0; > goto free_onfi_param_page; > } > > - crc = onfi_crc16(ONFI_CRC_BASE, (u8 *)&p[i], 254); > - if (crc == le16_to_cpu(p[i].crc)) { > - if (i) > - memcpy(p, &p[i], sizeof(*p)); > + crc = onfi_crc16(ONFI_CRC_BASE, (u8 *)&pbuf[i], 254); > + if (crc == le16_to_cpu(pbuf[i].crc)) { > + p = &pbuf[i]; > break; > } > } > > if (i == 3) { > - const void *srcbufs[3] = {p, p + 1, p + 2}; > - > + const void *srcbufs[3] = {pbuf, pbuf + 1, pbuf + 2}; > pr_warn("Could not find a valid ONFI parameter page, trying bit-wise majority to recover it\n"); > - nand_bit_wise_majority(srcbufs, ARRAY_SIZE(srcbufs), p, > - sizeof(*p)); > + nand_bit_wise_majority(srcbufs, ARRAY_SIZE(srcbufs), pbuf, > + sizeof(*pbuf)); > > - crc = onfi_crc16(ONFI_CRC_BASE, (u8 *)p, 254); > - if (crc != le16_to_cpu(p->crc)) { > + crc = onfi_crc16(ONFI_CRC_BASE, (u8 *)pbuf, 254); > + if (crc != le16_to_cpu(pbuf->crc)) { > pr_err("ONFI parameter recovery failed, aborting\n"); > goto free_onfi_param_page; > } > + p = pbuf; > } > > if (chip->manufacturer.desc && chip->manufacturer.desc->ops && > @@ -300,7 +299,7 @@ int nand_onfi_detect(struct nand_chip *chip) > chip->parameters.onfi = onfi; > > /* Identification done, free the full ONFI parameter page and exit */ > - kfree(p); > + kfree(pbuf); > > return 1; > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/