From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E130CC55186 for ; Sat, 25 Apr 2020 08:23:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B529C2071C for ; Sat, 25 Apr 2020 08:23:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FjbSrvom" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B529C2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3zVeBrFp4sL1IeRREvbqkTsN54voXFNGhwxdk9ssgfY=; b=FjbSrvomgxoq8j xRyn3Gpt9Cu5koUGewCDmTKuXoy/rzkukYz7eUhHzv1+x1Mj2qE9SWeQQFblwhT4B+v1p+jhkZXqa 82fqtHT+kIG0v9g+UACw4st8VgWOG6NLbAQjwypRXjYJm4AEEu+FI8iJmlUQAGy4OKWW6ho22jfWQ +nzveTMGVCQOsosNzciw4JitTQD0DaCalOkwoWQvt8i2TMWysoWX0vG8qf8r417ROnEa8NgqWpOQh w+jgyk7m4NLculse5CLYQvCLnOpbgfwC4lGWGhy4SLzNPVaTZvF+6eLPNaceScLna5Q3JAxXT4HAS tzHrm2pfg4BiXZl5os0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSG5D-0001kR-Gu; Sat, 25 Apr 2020 08:22:43 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSG50-0001iW-Hj for linux-mtd@lists.infradead.org; Sat, 25 Apr 2020 08:22:38 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id E2494275CEE; Sat, 25 Apr 2020 09:22:28 +0100 (BST) Date: Sat, 25 Apr 2020 10:22:25 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v2 3/9] mtd: rawnand: onfi: Fix redundancy detection check Message-ID: <20200425102225.002e740e@collabora.com> In-Reply-To: <20200424164042.26572-4-miquel.raynal@bootlin.com> References: <20200424164042.26572-1-miquel.raynal@bootlin.com> <20200424164042.26572-4-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200425_012237_169083_275BA5F1 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Thomas Petazzoni , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 24 Apr 2020 18:40:36 +0200 Miquel Raynal wrote: > During ONFI detection, the CRC derived from the parameter page and the > CRC supposed to be at the end of the parameter page are compared. If > they do not match, the second then the third copies of the page are > tried. > > The current implementation compares the newly derived CRC with the CRC > contained in the first page only. So if this particular CRC area has > been corrupted, then the detection will fail for a wrong reason. > > Fix this issue by checking the derived CRC against the right one. > This one probably deserves Fixes and Cc-stable tags. > Signed-off-by: Miquel Raynal > Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_onfi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/nand_onfi.c b/drivers/mtd/nand/raw/nand_onfi.c > index 0b879bd0a68c..8fe8d7bdd203 100644 > --- a/drivers/mtd/nand/raw/nand_onfi.c > +++ b/drivers/mtd/nand/raw/nand_onfi.c > @@ -173,7 +173,7 @@ int nand_onfi_detect(struct nand_chip *chip) > } > > if (onfi_crc16(ONFI_CRC_BASE, (u8 *)&p[i], 254) == > - le16_to_cpu(p->crc)) { > + le16_to_cpu(p[i].crc)) { > if (i) > memcpy(p, &p[i], sizeof(*p)); > break; ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/