From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>
Subject: Re: [PATCH v2 8/9] mtd: rawnand: jedec: Define the number of parameter pages
Date: Sat, 25 Apr 2020 10:26:46 +0200 [thread overview]
Message-ID: <20200425102646.43407584@collabora.com> (raw)
In-Reply-To: <20200424164042.26572-9-miquel.raynal@bootlin.com>
On Fri, 24 Apr 2020 18:40:41 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Use a macro to define the number of parameter page instead of
> hardcoding it everywhere.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/mtd/nand/raw/nand_jedec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/nand_jedec.c b/drivers/mtd/nand/raw/nand_jedec.c
> index 9b540e76f84f..0cd322a8be24 100644
> --- a/drivers/mtd/nand/raw/nand_jedec.c
> +++ b/drivers/mtd/nand/raw/nand_jedec.c
> @@ -16,6 +16,8 @@
>
> #include "internals.h"
>
> +#define JEDEC_PARAM_PAGES 3
> +
> /*
> * Check if the NAND chip is JEDEC compliant, returns 1 if it is, 0 otherwise.
> */
> @@ -47,7 +49,7 @@ int nand_jedec_detect(struct nand_chip *chip)
> goto free_jedec_param_page;
> }
>
> - for (i = 0; i < 3; i++) {
> + for (i = 0; i < JEDEC_PARAM_PAGES; i++) {
> ret = nand_read_data_op(chip, p, sizeof(*p), true);
> if (ret) {
> ret = 0;
> @@ -59,7 +61,7 @@ int nand_jedec_detect(struct nand_chip *chip)
> break;
> }
>
> - if (i == 3) {
> + if (i == JEDEC_PARAM_PAGES) {
> pr_err("Could not find valid JEDEC parameter page; aborting\n");
> goto free_jedec_param_page;
> }
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-25 8:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 16:40 [PATCH v2 0/9] Misc timing changes Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 1/9] mtd: rawnand: timings: Add mode information to the timings structure Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 2/9] mtd: rawnand: timings: Fix default tR_max and tCCS_min timings Miquel Raynal
2020-04-25 9:40 ` Sergei Shtylyov
2020-04-28 9:10 ` Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 3/9] mtd: rawnand: onfi: Fix redundancy detection check Miquel Raynal
2020-04-25 8:22 ` Boris Brezillon
2020-04-28 8:54 ` Miquel Raynal
2020-04-28 9:10 ` Boris Brezillon
2020-04-24 16:40 ` [PATCH v2 4/9] mtd: rawnand: onfi: Use intermediate variables to improve readability Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 5/9] mtd: rawnand: onfi: Define the number of parameter pages Miquel Raynal
2020-04-25 8:25 ` Boris Brezillon
2020-04-25 8:28 ` Boris Brezillon
2020-04-28 9:36 ` Miquel Raynal
2020-04-28 9:38 ` Boris Brezillon
2020-04-28 9:39 ` Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 6/9] mtd: rawnand: onfi: Avoid doing a copy of the parameter page Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 7/9] mtd: rawnand: onfi: Drop a useless parameter page read Miquel Raynal
2020-04-25 8:26 ` Boris Brezillon
2020-04-24 16:40 ` [PATCH v2 8/9] mtd: rawnand: jedec: Define the number of parameter pages Miquel Raynal
2020-04-25 8:26 ` Boris Brezillon [this message]
2020-04-24 16:40 ` [PATCH v2 9/9] mtd: rawnand: jedec: Use intermediate variables to improve readability Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425102646.43407584@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).