From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037A6C55185 for ; Sat, 25 Apr 2020 08:27:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96FFD2071C for ; Sat, 25 Apr 2020 08:27:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E2uNrpvG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96FFD2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AplCxqh6IgnsmIjxXjtgiQJT20Yyed49qpOWWPlF6UU=; b=E2uNrpvGSzNG1y FJ1coQf4lq5UZU+O5viGJzbefNzX4KeEzPL3kpE9QdoKXRchA8UgHe5VrVAw0UvQzFah+EqfVzfFW VkCqX213k+y46inKt4bJyL0dxKQIi04pI1CyW9Fgj4+JHRlp42shD4xVuuIdfkK+Y5gXBPdzvRxV1 EubFEgCTgVCA8puvedMqPg6yTr14m8iZioNQL6iyREru5ySmwL99mTGE4/d3hq6uZUhzQDGNcbWo5 hKXeC2TKF/Eqke1eRO5wwUsLMmYb+MDxT+mjH8Fdb9nSojf1EjYTAJCXn72UPVoukNo6UdOSvOqpc aGToOWkztx2HsukFEPbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSG9F-0005S1-2R; Sat, 25 Apr 2020 08:26:53 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSG9C-0005Qy-QU for linux-mtd@lists.infradead.org; Sat, 25 Apr 2020 08:26:52 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9239A2A2E93; Sat, 25 Apr 2020 09:26:49 +0100 (BST) Date: Sat, 25 Apr 2020 10:26:46 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v2 8/9] mtd: rawnand: jedec: Define the number of parameter pages Message-ID: <20200425102646.43407584@collabora.com> In-Reply-To: <20200424164042.26572-9-miquel.raynal@bootlin.com> References: <20200424164042.26572-1-miquel.raynal@bootlin.com> <20200424164042.26572-9-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200425_012650_997407_31C52274 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Thomas Petazzoni , Tudor Ambarus Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 24 Apr 2020 18:40:41 +0200 Miquel Raynal wrote: > Use a macro to define the number of parameter page instead of > hardcoding it everywhere. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_jedec.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_jedec.c b/drivers/mtd/nand/raw/nand_jedec.c > index 9b540e76f84f..0cd322a8be24 100644 > --- a/drivers/mtd/nand/raw/nand_jedec.c > +++ b/drivers/mtd/nand/raw/nand_jedec.c > @@ -16,6 +16,8 @@ > > #include "internals.h" > > +#define JEDEC_PARAM_PAGES 3 > + > /* > * Check if the NAND chip is JEDEC compliant, returns 1 if it is, 0 otherwise. > */ > @@ -47,7 +49,7 @@ int nand_jedec_detect(struct nand_chip *chip) > goto free_jedec_param_page; > } > > - for (i = 0; i < 3; i++) { > + for (i = 0; i < JEDEC_PARAM_PAGES; i++) { > ret = nand_read_data_op(chip, p, sizeof(*p), true); > if (ret) { > ret = 0; > @@ -59,7 +61,7 @@ int nand_jedec_detect(struct nand_chip *chip) > break; > } > > - if (i == 3) { > + if (i == JEDEC_PARAM_PAGES) { > pr_err("Could not find valid JEDEC parameter page; aborting\n"); > goto free_jedec_param_page; > } ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/