From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4039C55185 for ; Sat, 25 Apr 2020 08:33:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C42CD20706 for ; Sat, 25 Apr 2020 08:33:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oj+m18WY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C42CD20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r/japy/G2/pahAmPVt3oiF/6SUtnUDmULvuXKlRqk7Y=; b=oj+m18WYoRqRkI Z4IJ+zgHjCdqMiETF3RQN6GNUJrkkMdD79LvS/627GkQ2/pBlLiK/6+v5cNa0BoO23cNpg0s2TMP/ Dl/x1sIXl/TtyJYbRW5egYs4IromObPMypqbEp6gO7OYYji9CE0ZUUsjDt2I7Y0ZFahO/KDrimuu5 94sep9rNqGN8K9bhvriHiKmuQquZ+Z3i45ANDURTegRC2Wq6pEZ812hoIIeEG/7qudOinKG5OE6eQ CGk59WwcHSNgCzbpICqXeZcwUmAFFxtwx22GH6PxRTEkM9EY7TnGC319i33qBfZk+KmZN6wzyHhSj B2sKoOm1IFF1bCI1bRzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSGFb-0000v3-46; Sat, 25 Apr 2020 08:33:27 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSGFY-0000uE-3x for linux-mtd@lists.infradead.org; Sat, 25 Apr 2020 08:33:25 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C62672A2E93; Sat, 25 Apr 2020 09:33:22 +0100 (BST) Date: Sat, 25 Apr 2020 10:33:20 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH 01/10] mtd: rawnand: Translate obscure bitfields into readable macros Message-ID: <20200425103320.4b409216@collabora.com> In-Reply-To: <20200424173631.14311-2-miquel.raynal@bootlin.com> References: <20200424173631.14311-1-miquel.raynal@bootlin.com> <20200424173631.14311-2-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200425_013324_290004_ABB482F6 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 24 Apr 2020 19:36:22 +0200 Miquel Raynal wrote: > /* > * This option could be defined by controller drivers to protect against > * kmap'ed, vmalloc'ed highmem buffers being passed from upper layers > */ > -#define NAND_USE_BOUNCE_BUFFER 0x00100000 > +#define NAND_USE_BOUNCE_BUFFER BIT(22) ^BIT(20) > > /* > * In case your controller is implementing ->legacy.cmd_ctrl() and is relying > @@ -207,20 +207,20 @@ enum nand_ecc_algo { > * If your controller already takes care of this delay, you don't need to set > * this flag. > */ > -#define NAND_WAIT_TCCS 0x00200000 > +#define NAND_WAIT_TCCS BIT(21) > > /* > * Whether the NAND chip is a boot medium. Drivers might use this information > * to select ECC algorithms supported by the boot ROM or similar restrictions. > */ > -#define NAND_IS_BOOT_MEDIUM 0x00400000 > +#define NAND_IS_BOOT_MEDIUM BIT(20) ^ BIT(22) The rest looks good, feel fre to add Reviewed-by: Boris Brezillon once those 2 mistakes are fixed. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/