From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F69C55186 for ; Sat, 25 Apr 2020 08:45:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA640206ED for ; Sat, 25 Apr 2020 08:45:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QGi/yFy0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA640206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22gwZznk8eBbqfz+f4KpJ50eldeis8dHzYzBz3hPYQI=; b=QGi/yFy0bU5Pzp rPLov150jrfhjL1t/uYll0jrsvoppRieTaoeHokScCNKw+gCJpXBO0ATR+2C556IZIaVgbE3/bWtz OUwAtXmRJNJ+x0RMAzP1+JZeCi2ztpF9fSo8bIIQsK9HJ+FMvb5Yyrgs2YUyVTz7CFXZOn/Bs46Ac Rp8pZyT8XQLElcu1n4Ar9NucgNsv71CIr6rCnQzG+sB9DGZPOUayoNEZ7V38tlkyBB/8jbLkIgWzq DXTObU4VNjmeAvkE48bzQ66uwZQ5MB1owAztP5c4vA6BWoU8TPwIPa2fp23ERHpxI5Aj2DfRY77oO CBNBEYRk0CSD5d6/NgeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSGR9-0002dC-OJ; Sat, 25 Apr 2020 08:45:23 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSGR7-0002cX-Hq for linux-mtd@lists.infradead.org; Sat, 25 Apr 2020 08:45:22 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 472A32A2F11; Sat, 25 Apr 2020 09:45:20 +0100 (BST) Date: Sat, 25 Apr 2020 10:45:17 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH 06/10] mtd: rawnand: Avoid indirect access to ->data_buf() Message-ID: <20200425104517.59bf71dc@collabora.com> In-Reply-To: <20200424173631.14311-7-miquel.raynal@bootlin.com> References: <20200424173631.14311-1-miquel.raynal@bootlin.com> <20200424173631.14311-7-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200425_014521_716035_08250628 X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Fri, 24 Apr 2020 19:36:27 +0200 Miquel Raynal wrote: > The logic in nand_do_read_ops() is to use a bufpoi variable, either > set to the original buffer, or set to a bounce buffer which in the end > happens to be chip->data_buf depending on the value of the > use_bounce_buf boolean. This is not a reason to call chip->data_buf > directly when we know that we are using the bounce buffer. Let's use > bufpoi instead to be consistent. > > Signed-off-by: Miquel Raynal Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/raw/nand_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index 0e2dd4c1b44c..15a9189b2307 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -3243,7 +3243,7 @@ static int nand_do_read_ops(struct nand_chip *chip, loff_t from, > /* Invalidate page cache */ > chip->pagecache.page = -1; > } > - memcpy(buf, chip->data_buf + col, bytes); > + memcpy(buf, bufpoi + col, bytes); > } > > if (unlikely(oob)) { ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/