From: Boris Brezillon <boris.brezillon@collabora.com>
To: David Woodhouse <dwmw2@infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH 17/17] mtd: rawnand: s/uint{8,16,32}_t/u{8,16,32}/
Date: Mon, 27 Apr 2020 10:25:29 +0200 [thread overview]
Message-ID: <20200427102529.5953c8fb@collabora.com> (raw)
In-Reply-To: <20200427082028.394719-19-boris.brezillon@collabora.com>
On Mon, 27 Apr 2020 10:20:28 +0200
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> Replace uint{8,16,32}_t by u{8,16,32} to make checkpatch happy.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Please ignore that one, it's just a duplicate of the other patch 17
but with a wrong prefix in the subject.
> ---
> drivers/mtd/nand/raw/cafe_nand.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c
> index 955dc78c57be..658c95804297 100644
> --- a/drivers/mtd/nand/raw/cafe_nand.c
> +++ b/drivers/mtd/nand/raw/cafe_nand.c
> @@ -151,7 +151,7 @@ struct cafe_priv {
> struct pci_dev *pdev;
> void __iomem *mmio;
> struct rs_control *rs;
> - uint32_t ctl2;
> + u32 ctl2;
> bool usedma;
> dma_addr_t dmaaddr;
> unsigned char *dmabuf;
> @@ -224,7 +224,7 @@ static irqreturn_t cafe_nand_interrupt(int irq, void *id)
> struct mtd_info *mtd = id;
> struct nand_chip *chip = mtd_to_nand(mtd);
> struct cafe_priv *cafe = nand_get_controller_data(chip);
> - uint32_t irqs = cafe_readl(cafe, NAND_IRQ);
> + u32 irqs = cafe_readl(cafe, NAND_IRQ);
> cafe_writel(cafe,
> irqs & ~(CAFE_NAND_IRQ_CMD_DONE | CAFE_NAND_IRQ_DMA_DONE),
> NAND_IRQ);
> @@ -255,7 +255,7 @@ static int cafe_nand_read_oob(struct nand_chip *chip, int page)
> * The hw generator calculates the error syndrome automatically. Therefore
> * we need a special oob layout and handling.
> */
> -static int cafe_nand_read_page(struct nand_chip *chip, uint8_t *buf,
> +static int cafe_nand_read_page(struct nand_chip *chip, u8 *buf,
> int oob_required, int page)
> {
> struct mtd_info *mtd = nand_to_mtd(chip);
> @@ -283,8 +283,8 @@ static int cafe_nand_read_page(struct nand_chip *chip, uint8_t *buf,
> int i, n;
>
> for (i=0; i<8; i+=2) {
> - uint32_t tmp = cafe_readl(cafe, NAND_ECC_SYN_REG(i));
> - uint16_t idx;
> + u32 tmp = cafe_readl(cafe, NAND_ECC_SYN_REG(i));
> + u16 idx;
>
> idx = FIELD_GET(CAFE_NAND_ECC_SYN_FIELD(i), tmp);
> syn[i] = cafe->rs->codec->index_of[idx];
> @@ -380,11 +380,11 @@ static const struct mtd_ooblayout_ops cafe_ooblayout_ops = {
>
> /* Ick. The BBT code really ought to be able to work this bit out
> for itself from the above, at least for the 2KiB case */
> -static uint8_t cafe_bbt_pattern_2048[] = { 'B', 'b', 't', '0' };
> -static uint8_t cafe_mirror_pattern_2048[] = { '1', 't', 'b', 'B' };
> +static u8 cafe_bbt_pattern_2048[] = { 'B', 'b', 't', '0' };
> +static u8 cafe_mirror_pattern_2048[] = { '1', 't', 'b', 'B' };
>
> -static uint8_t cafe_bbt_pattern_512[] = { 0xBB };
> -static uint8_t cafe_mirror_pattern_512[] = { 0xBC };
> +static u8 cafe_bbt_pattern_512[] = { 0xBB };
> +static u8 cafe_mirror_pattern_512[] = { 0xBC };
>
>
> static struct nand_bbt_descr cafe_bbt_main_descr_2048 = {
> @@ -429,7 +429,7 @@ static struct nand_bbt_descr cafe_bbt_mirror_descr_512 = {
>
>
> static int cafe_nand_write_page(struct nand_chip *chip,
> - const uint8_t *buf, int oob_required,
> + const u8 *buf, int oob_required,
> int page)
> {
> struct mtd_info *mtd = nand_to_mtd(chip);
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-27 8:29 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 8:20 [PATCH 00/17] mtd: rawnand: cafe: Convert to exec_op() (and more) Boris Brezillon
2020-04-27 8:20 ` [PATCH 01/17] mtd: rawnand: cafe: Get rid of an inaccurate kernel doc header Boris Brezillon
2020-04-27 19:33 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 02/17] mtd: rawnand: cafe: Rename cafe_nand_write_page_lowlevel() Boris Brezillon
2020-04-27 19:33 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 03/17] mtd: rawnand: cafe: Use a correct ECC mode and pass the ECC alg Boris Brezillon
2020-04-27 19:34 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 04/17] mtd: rawnand: cafe: Include linux/io.h instead of asm/io.h Boris Brezillon
2020-04-27 19:35 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 05/17] mtd: rawnand: cafe: Demistify register fields Boris Brezillon
2020-04-27 19:42 ` Miquel Raynal
2020-04-28 6:06 ` Boris Brezillon
2020-04-27 8:20 ` [PATCH 06/17] mtd: rawnand: cafe: Factor out the controller initialization logic Boris Brezillon
2020-04-27 19:45 ` Miquel Raynal
2020-04-28 6:06 ` Boris Brezillon
2020-04-27 8:20 ` [PATCH 07/17] mtd: rawnand: cafe: Get rid of the debug module param Boris Brezillon
2020-04-27 19:46 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 08/17] mtd: rawnand: cafe: Use devm_kzalloc and devm_request_irq() Boris Brezillon
2020-04-27 19:47 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 09/17] mtd: rawnand: cafe: Get rid of a useless label Boris Brezillon
2020-04-27 19:47 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 10/17] mtd: rawnand: cafe: Explicitly inherit from nand_controller Boris Brezillon
2020-04-27 19:49 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 11/17] mtd: rawnand: cafe: Don't leave ECC enabled in the write path Boris Brezillon
2020-04-27 19:51 ` Miquel Raynal
2020-04-28 6:08 ` Boris Brezillon
2020-04-27 8:20 ` [PATCH 12/17] mtd: rawnand: cafe: Don't split things when reading/writing a page Boris Brezillon
2020-04-27 19:53 ` Miquel Raynal
2020-04-28 6:20 ` Boris Brezillon
2020-04-28 7:44 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 13/17] mtd: rawnand: cafe: Add exec_op() support Boris Brezillon
2020-04-27 19:59 ` Miquel Raynal
2020-04-28 6:24 ` Boris Brezillon
[not found] ` <20200502111410.330584-1-lkundrak@v3.sk>
2020-05-02 13:18 ` Boris Brezillon
[not found] ` <20200502191843.GA363829@furthur.local>
2020-05-02 22:34 ` Boris Brezillon
[not found] ` <20200503060610.GA386731@furthur.local>
2020-05-03 7:04 ` Boris Brezillon
2020-05-03 7:26 ` Boris Brezillon
[not found] ` <20200503175537.GA404453@furthur.local>
2020-05-03 19:49 ` Boris Brezillon
[not found] ` <20200503075208.GA387473@furthur.local>
2020-05-03 8:13 ` Boris Brezillon
2020-05-03 8:35 ` Boris Brezillon
2020-05-09 20:10 ` Boris Brezillon
2020-04-27 8:20 ` [PATCH 14/17] mtd: rawnand: cafe: Get rid of the legacy interface implementation Boris Brezillon
2020-04-27 20:00 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 15/17] mtd: rawnand: cafe: Adjust the cafe_{read, write}_buf() prototypes Boris Brezillon
2020-04-27 20:00 ` [PATCH 15/17] mtd: rawnand: cafe: Adjust the cafe_{read,write}_buf() prototypes Miquel Raynal
2020-04-28 6:24 ` Boris Brezillon
2020-04-27 8:20 ` [PATCH 16/17] mtd: rawnand: cafe: Handle non-32bit aligned reads/writes Boris Brezillon
2020-04-27 20:04 ` Miquel Raynal
2020-04-28 6:26 ` Boris Brezillon
2020-04-27 8:20 ` [PATCH 17/17] mtd: rawnand: cafe: s/uint{8,16,32}_t/u{8,16,32}/ Boris Brezillon
2020-04-27 20:05 ` Miquel Raynal
2020-04-27 8:20 ` [PATCH 17/17] mtd: rawnand: s/uint{8,16,32}_t/u{8,16,32}/ Boris Brezillon
2020-04-27 8:25 ` Boris Brezillon [this message]
2020-04-29 6:37 ` [PATCH 00/17] mtd: rawnand: cafe: Convert to exec_op() (and more) Thomas Petazzoni
2020-04-29 8:28 ` Boris Brezillon
[not found] ` <20200501055209.GA44510@furthur.local>
2020-05-01 6:21 ` Boris Brezillon
[not found] ` <20200502112732.330971-1-lkundrak@v3.sk>
2020-05-02 13:15 ` Boris Brezillon
2020-05-08 10:32 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427102529.5953c8fb@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).