From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Vignesh Raghavendra" <vigneshr@ti.com>,
"Tudor Ambarus" <tudor.ambarus@microchip.com>,
"Richard Weinberger" <richard@nod.at>,
"Boris Brezillon" <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org, "Rafał Miłecki" <rafal@milecki.pl>,
bcm-kernel-feedback-list@broadcom.com,
openwrt-devel@lists.openwrt.org
Subject: Re: [PATCH 9/9] mtd: rawnand: bcm47xx: Move the driver to drivers/mtd/nand/raw/
Date: Mon, 27 Apr 2020 20:40:51 +0200 [thread overview]
Message-ID: <20200427204051.5306ed33@collabora.com> (raw)
In-Reply-To: <20200427192417.112a69b4@xps13>
On Mon, 27 Apr 2020 19:24:17 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Hi Boris,
>
> Boris Brezillon <boris.brezillon@collabora.com> wrote on Sun, 19 Apr
> 2020 14:51:40 +0200:
>
> > Now that we have a single we can move it to the directory where all
> > single source file drivers live.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> > ---
> > drivers/mtd/nand/raw/Makefile | 1 +
> > drivers/mtd/nand/raw/{bcm47xxnflash => }/bcm47xxnflash.c | 0
> > drivers/mtd/nand/raw/bcm47xxnflash/Makefile | 2 --
> > 3 files changed, 1 insertion(+), 2 deletions(-)
> > rename drivers/mtd/nand/raw/{bcm47xxnflash => }/bcm47xxnflash.c (100%)
> > delete mode 100644 drivers/mtd/nand/raw/bcm47xxnflash/Makefile
>
> Here are two independent comments:
>
> 1/ I think calling the file bcm47xxn-nand-controller.c would best fit
> todays policy.
Sure I can do that.
>
> 2/ I am not sure there is an interest in doing the merge +
> move/rename in separate steps. It's always a pain to follow changes in
> a file with git blame when code get's moved around so I would prefer
> doing this in a single change, what do you think?
Great minds think alike: I was planning to merge those 2 patches in v2
;-). It's indeed not necessary to do it in 2 steps.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-04-27 18:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 12:51 [PATCH 0/9] mtd: rawnand: bcm47xx: Convert the driver exec_op() Boris Brezillon
2020-04-19 12:51 ` [PATCH 1/9] mtd: rawnand: Add an is_last flag to nand_subop Boris Brezillon
2020-04-27 17:02 ` Miquel Raynal
2020-04-27 17:03 ` Miquel Raynal
2020-04-27 17:03 ` Miquel Raynal
2020-04-19 12:51 ` [PATCH 2/9] mtd: rawnand: bcm47xx: Drop dependency on BCMA Boris Brezillon
2020-04-19 12:51 ` [PATCH 3/9] mtd: rawnand: bcm47xx: Allow compiling the driver when COMPILE_TEST=y Boris Brezillon
2020-04-19 12:51 ` [PATCH 4/9] mtd: rawnand: bcm47xx: Demistify a few more things Boris Brezillon
2020-04-27 17:07 ` Miquel Raynal
2020-04-27 18:31 ` Boris Brezillon
2020-04-19 12:51 ` [PATCH 5/9] mtd: rawnand: bcm47xx: Implement the exec_op() interface Boris Brezillon
2020-04-27 17:18 ` Miquel Raynal
2020-04-27 18:35 ` Boris Brezillon
2020-04-27 18:49 ` Miquel Raynal
2020-04-19 12:51 ` [PATCH 6/9] mtd: rawnand: bcm47xx: Get rid of the legacy implementation Boris Brezillon
2020-04-27 17:19 ` Miquel Raynal
2020-04-27 18:39 ` Boris Brezillon
2020-04-19 12:51 ` [PATCH 7/9] mtd: rawnand: bcm47xx: Simplify the init() function Boris Brezillon
2020-04-27 17:20 ` Miquel Raynal
2020-04-19 12:51 ` [PATCH 8/9] mtd: rawnand: bcm47xx: Merge all source files Boris Brezillon
2020-04-27 17:27 ` Miquel Raynal
2020-04-19 12:51 ` [PATCH 9/9] mtd: rawnand: bcm47xx: Move the driver to drivers/mtd/nand/raw/ Boris Brezillon
2020-04-20 11:32 ` Boris Brezillon
2020-04-27 17:24 ` Miquel Raynal
2020-04-27 18:40 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427204051.5306ed33@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=openwrt-devel@lists.openwrt.org \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).