From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1860CC4CECD for ; Mon, 27 Apr 2020 18:41:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF35721D80 for ; Mon, 27 Apr 2020 18:41:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZHhUkNTu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF35721D80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LmEfuT7VjkSyrwbv28Lqx/SNhAqDygE5sMusGxlPvls=; b=ZHhUkNTuLYUG0r FSMihpBe9UusYY+hZI0oADUfGgpW4EbRs2IouNG0RSUb35dzGvlZz4o/PZlLben2lps0F1E8RulRJ twoP4aK8Qn4jhy3iBjo9MZU/HC14kn63+kAphGyDdAerRSOAztxZZ991AuXMlOIzL3qGXopOYzxfw 3hnKi+hPJYaPmbM4TIOlg5g59/eN7tHZ3N1vbW5HzgYui5kpvf2MXJEeNg0VvGCqZwVbwjZu015PM OWU0y7bZ0YLL2ADlWk9Dj+eTZYHSkwrBZbmSpwlc3pbNmO/FrbDzTgEMHfEwC1DJAyobpubBGhpfS 8zBbbla8UCfEs3zyDS8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT8go-00053O-SR; Mon, 27 Apr 2020 18:41:10 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT8gZ-0004i0-91 for linux-mtd@lists.infradead.org; Mon, 27 Apr 2020 18:40:56 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id F1D682A0DF3; Mon, 27 Apr 2020 19:40:53 +0100 (BST) Date: Mon, 27 Apr 2020 20:40:51 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH 9/9] mtd: rawnand: bcm47xx: Move the driver to drivers/mtd/nand/raw/ Message-ID: <20200427204051.5306ed33@collabora.com> In-Reply-To: <20200427192417.112a69b4@xps13> References: <20200419125140.1307309-1-boris.brezillon@collabora.com> <20200419125140.1307309-10-boris.brezillon@collabora.com> <20200427192417.112a69b4@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_114055_460308_878D7CD1 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Boris Brezillon , linux-mtd@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , bcm-kernel-feedback-list@broadcom.com, openwrt-devel@lists.openwrt.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 27 Apr 2020 19:24:17 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Sun, 19 Apr > 2020 14:51:40 +0200: > > > Now that we have a single we can move it to the directory where all > > single source file drivers live. > > > > Signed-off-by: Boris Brezillon > > --- > > drivers/mtd/nand/raw/Makefile | 1 + > > drivers/mtd/nand/raw/{bcm47xxnflash => }/bcm47xxnflash.c | 0 > > drivers/mtd/nand/raw/bcm47xxnflash/Makefile | 2 -- > > 3 files changed, 1 insertion(+), 2 deletions(-) > > rename drivers/mtd/nand/raw/{bcm47xxnflash => }/bcm47xxnflash.c (100%) > > delete mode 100644 drivers/mtd/nand/raw/bcm47xxnflash/Makefile > > Here are two independent comments: > > 1/ I think calling the file bcm47xxn-nand-controller.c would best fit > todays policy. Sure I can do that. > > 2/ I am not sure there is an interest in doing the merge + > move/rename in separate steps. It's always a pain to follow changes in > a file with git blame when code get's moved around so I would prefer > doing this in a single change, what do you think? Great minds think alike: I was planning to merge those 2 patches in v2 ;-). It's indeed not necessary to do it in 2 steps. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/