From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Joe Perches <joe@perches.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/3] mtd: lpddr: Replace printk with pr_notice
Date: Mon, 27 Apr 2020 21:15:34 +0200 [thread overview]
Message-ID: <20200427211534.01b57587@xps13> (raw)
In-Reply-To: <67c4b34d-019d-e4c9-ebd2-3a8477470048@embeddedor.com>
Hi Gustavo,
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote on Mon, 27 Apr
2020 14:10:36 -0500:
> On 4/27/20 14:01, Joe Perches wrote:
> > On Mon, 2020-04-27 at 14:03 -0500, Gustavo A. R. Silva wrote:
> >> pr_notice is preferred over printk.
> >
> > So is coalescing formats
> >
> > ? diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h
> > []
> >> @@ -127,31 +127,31 @@ static inline void print_drs_error(unsigned dsr)
> >> int prog_status = (dsr & DSR_RPS) >> 8;
> >>
> >> if (!(dsr & DSR_AVAILABLE))
> >> - printk(KERN_NOTICE"DSR.15: (0) Device not Available\n");
> >> + pr_notice("DSR.15: (0) Device not Available\n");
> >> if ((prog_status & 0x03) == 0x03)
> >> - printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid "
> >> + pr_notice("DSR.9,8: (11) Attempt to program invalid "
> >> "half with 41h command\n");
> >
> > pr_notice("DSR.9,8: (11) Attempt to program invalid half with 41h command\n");
> >
>
> I didn't want to mess with the rest of format, because some maintainers
> don't like that. If Miquel is OK with that, I can fix that up, too.
>
> Thanks
> --
> Gustavo
I'm fine with it in this case, just mention it in the commit log,
please.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-27 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 19:00 [PATCH 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Gustavo A. R. Silva
2020-04-27 19:02 ` [PATCH 1/3] mtd: lpddr: Fix bad logic " Gustavo A. R. Silva
2020-04-27 19:03 ` [PATCH 2/3] mtd: lpddr: Replace printk with pr_notice Gustavo A. R. Silva
2020-04-27 19:01 ` Joe Perches
2020-04-27 19:10 ` Gustavo A. R. Silva
2020-04-27 19:15 ` Joe Perches
2020-04-27 19:21 ` Miquel Raynal
2020-04-27 19:15 ` Miquel Raynal [this message]
2020-04-27 19:04 ` [PATCH 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c Gustavo A. R. Silva
2020-04-27 19:03 ` Joe Perches
2020-04-27 19:11 ` Gustavo A. R. Silva
2020-08-11 23:47 ` [PATCH 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Joe Perches
2020-08-12 7:23 ` Miquel Raynal
2020-08-12 15:00 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427211534.01b57587@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=gustavo@embeddedor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).