From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88EFFC83004 for ; Tue, 28 Apr 2020 06:06:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BF47206B9 for ; Tue, 28 Apr 2020 06:06:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oqkBbKqR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BF47206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sI6p5IjOpSWBffOmFbWQgPa+oOnoIjMvpFZX8xZJkfo=; b=oqkBbKqReo4YBB 4SM215yzzqGNDXO8fu7l4XvHYwvWghEfpM9oTwhZzxhYwcsGkKSJGmTpGMjGiOba8WM7mnkUikDWz E+Ro0Zwt6zmZyOFVyOplSGagW5fyWw1ew3yHSGeqJe1rmAJmkQQVC5RLa/1UpYU4xk4n16Rxkm0P6 lwh+jUtqaa1EQQKa+bnGn7WxTl9N+kGv7bwjgincXF1Fham79eFaTgf92Bu0GVneVyhMzRsxqlgC7 nfEKVkBtyfnO+pZjkrQ8q5jY2pu07GbvDqll3uAgvast31gY+1Mate6DjocrMTL+6Tx9RD+ckd9W1 rTk8lQrgaPIkQvHRfnoQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTJNu-0002oy-GQ; Tue, 28 Apr 2020 06:06:22 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTJNr-0002nc-Hr for linux-mtd@lists.infradead.org; Tue, 28 Apr 2020 06:06:20 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id EBAF42A0B89; Tue, 28 Apr 2020 07:06:11 +0100 (BST) Date: Tue, 28 Apr 2020 08:06:07 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH 05/17] mtd: rawnand: cafe: Demistify register fields Message-ID: <20200428080607.237a2591@collabora.com> In-Reply-To: <20200427214116.3ea7fa82@xps13> References: <20200427082028.394719-1-boris.brezillon@collabora.com> <20200427082028.394719-6-boris.brezillon@collabora.com> <20200427214116.3ea7fa82@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_230619_720968_53DABBD7 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, Tudor Ambarus , David Woodhouse , Vignesh Raghavendra , Richard Weinberger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 27 Apr 2020 21:42:11 +0200 Miquel Raynal wrote: > > struct cafe_priv { > > struct nand_chip nand; > > @@ -104,7 +195,8 @@ static const char *part_probes[] = { "cmdlinepart", "RedBoot", NULL }; > > static int cafe_device_ready(struct nand_chip *chip) > > { > > struct cafe_priv *cafe = nand_get_controller_data(chip); > > - int result = !!(cafe_readl(cafe, NAND_STATUS) & 0x40000000); > > + int result = !!(cafe_readl(cafe, NAND_STATUS) & > > + CAFE_NAND_STATUS_FLASH_BUSY); > > uint32_t irqs = cafe_readl(cafe, NAND_IRQ); > > > > cafe_writel(cafe, irqs, NAND_IRQ); > > [...] > > > @@ -318,14 +430,14 @@ static void cafe_select_chip(struct nand_chip *chip, int chipnr) > > { > > struct cafe_priv *cafe = nand_get_controller_data(chip); > > > > + if (chipnr < 0 || chipnr > 1) > > + return; > > + > > I think this change should not be part of this patch? Or dropped entirely, since we're getting rid of this function anyway. > > > cafe_dev_dbg(&cafe->pdev->dev, "select_chip %d\n", chipnr); > > > > /* Mask the appropriate bit into the stored value of ctl1 > > which will be used by cafe_nand_cmdfunc() */ > > - if (chipnr) > > - cafe->ctl1 |= CTRL1_CHIPSELECT; > > - else > > - cafe->ctl1 &= ~CTRL1_CHIPSELECT; > > + cafe->ctl1 |= CAFE_FIELD_PREP(NAND_CTRL1, CE, chipnr); > > I don't master these macros yet, but are you sure CTRL1_CHIPSELECT will > actually get cleared if (!chipnr) ? You're correct, I only ever set the field. I'll fix that. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/