linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-mtd@lists.infradead.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>
Subject: Re: [PATCH v2 3/9] mtd: rawnand: onfi: Fix redundancy detection check
Date: Tue, 28 Apr 2020 11:10:54 +0200	[thread overview]
Message-ID: <20200428111054.4a8cfd26@collabora.com> (raw)
In-Reply-To: <20200428105444.0778d750@xps13>

On Tue, 28 Apr 2020 10:54:44 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hi Boris,
> 
> Boris Brezillon <boris.brezillon@collabora.com> wrote on Sat, 25 Apr
> 2020 10:22:25 +0200:
> 
> > On Fri, 24 Apr 2020 18:40:36 +0200
> > Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >   
> > > During ONFI detection, the CRC derived from the parameter page and the
> > > CRC supposed to be at the end of the parameter page are compared. If
> > > they do not match, the second then the third copies of the page are
> > > tried.
> > > 
> > > The current implementation compares the newly derived CRC with the CRC
> > > contained in the first page only. So if this particular CRC area has
> > > been corrupted, then the detection will fail for a wrong reason.
> > > 
> > > Fix this issue by checking the derived CRC against the right one.
> > >     
> >   
> 
> Yes, but given the fact that we moved this code out of nand_base.c
> sending it to stable would not apply, I don't know what's best in this
> case?

It would at least be backported to a few releases, and you can always
provide a replacement when Greg sends you the 'patch did not apply'
notice. So yes, I think it's worth adding a cc-stable tag here.

> 
> The faulty commit being
> 39138c1f4a31 mtd: rawnand: use bit-wise majority to recover the ONFI param page
> 
> > This one probably deserves Fixes and Cc-stable tags.
> >   
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> > > ---
> > >  drivers/mtd/nand/raw/nand_onfi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/mtd/nand/raw/nand_onfi.c b/drivers/mtd/nand/raw/nand_onfi.c
> > > index 0b879bd0a68c..8fe8d7bdd203 100644
> > > --- a/drivers/mtd/nand/raw/nand_onfi.c
> > > +++ b/drivers/mtd/nand/raw/nand_onfi.c
> > > @@ -173,7 +173,7 @@ int nand_onfi_detect(struct nand_chip *chip)
> > >  		}
> > >  
> > >  		if (onfi_crc16(ONFI_CRC_BASE, (u8 *)&p[i], 254) ==
> > > -				le16_to_cpu(p->crc)) {
> > > +		    le16_to_cpu(p[i].crc)) {
> > >  			if (i)
> > >  				memcpy(p, &p[i], sizeof(*p));
> > >  			break;    
> >   
> 
> Thanks,
> Miquèl


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-04-28  9:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 16:40 [PATCH v2 0/9] Misc timing changes Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 1/9] mtd: rawnand: timings: Add mode information to the timings structure Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 2/9] mtd: rawnand: timings: Fix default tR_max and tCCS_min timings Miquel Raynal
2020-04-25  9:40   ` Sergei Shtylyov
2020-04-28  9:10     ` Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 3/9] mtd: rawnand: onfi: Fix redundancy detection check Miquel Raynal
2020-04-25  8:22   ` Boris Brezillon
2020-04-28  8:54     ` Miquel Raynal
2020-04-28  9:10       ` Boris Brezillon [this message]
2020-04-24 16:40 ` [PATCH v2 4/9] mtd: rawnand: onfi: Use intermediate variables to improve readability Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 5/9] mtd: rawnand: onfi: Define the number of parameter pages Miquel Raynal
2020-04-25  8:25   ` Boris Brezillon
2020-04-25  8:28     ` Boris Brezillon
2020-04-28  9:36     ` Miquel Raynal
2020-04-28  9:38       ` Boris Brezillon
2020-04-28  9:39         ` Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 6/9] mtd: rawnand: onfi: Avoid doing a copy of the parameter page Miquel Raynal
2020-04-24 16:40 ` [PATCH v2 7/9] mtd: rawnand: onfi: Drop a useless parameter page read Miquel Raynal
2020-04-25  8:26   ` Boris Brezillon
2020-04-24 16:40 ` [PATCH v2 8/9] mtd: rawnand: jedec: Define the number of parameter pages Miquel Raynal
2020-04-25  8:26   ` Boris Brezillon
2020-04-24 16:40 ` [PATCH v2 9/9] mtd: rawnand: jedec: Use intermediate variables to improve readability Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428111054.4a8cfd26@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).