Re: [PATCH v4 02/16] spi: atmel-quadspi: reject DTR ops

Mark Brown
2020-04-30T12:19:50Z

[-- Attachment #1.1: Type: text/plain, Size: 1106 bytes --]

On Thu, Apr 30, 2020 at 05:47:39PM +0530, Pratyush Yadav wrote:

> Most other controllers either don't specify a supports_op function at
> all, in which case spi_mem_default_supports_op() is called, or do their
> custom logic and then call spi_mem_default_supports_op(). In both those
> cases, DTR ops would get rejected because of the call to
> spi_mem_default_supports_op(). So they do not need to add the check
> explicitly there.

> The two exceptions are atmel-quadspi and spi-mtk-nor (which I missed
> updating). They don't call the default supports_op, so they need to be
> updated to explicitly to reject DTR ops.

OK.

> Earlier versions of this series discovered the DTR capability from
> devicetree. In that case, no change would be required at all, but review
> comments suggested I drop those changes. Instead, the controllers should
> accept/reject DTR ops in their supports_op hooks.

It definitely shouldn't be in device tree, this is something that the
silicon supports so we should already be able to figure out if we can
use it with just the compatible.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]