From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD7AC3A5A9 for ; Sat, 2 May 2020 16:35:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F7D721775 for ; Sat, 2 May 2020 16:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AnCFpfrv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F7D721775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fi0Yq+A3ZLI5fJO5UtSfNnQ7t1j0d3osaZh3BH1TbBs=; b=AnCFpfrvca4YCj 0R2eqh9OP5xZ60QgVBd7jD+m0GyDZoees1SlP0m4DCB0uJgjprV4VcutGhacJ0u2pfR27CO4OIINN 5cavBvtlj9o0aWP8tRRQHcX/rW7PRkRlCa9kZ61vRAdl2NjtkAFUYhk1nB5uTMvPIcbrJYLhQWR7w 5RsHr7132zmTlsaG1mXDLb30g5eeZdFLn1kEDkLk6cF48BcPVEiDY+sajpnWZX+qUtujDJzCwHLSg LH3vGBSNQqWRLItYonjXi2zoih9l5+PyInXSVEsFmNuHb79UOiECkeJu2StnlvpxKe//G1R+h8/ow ALvCVowBuPEOD0atMmSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUv6n-0003fV-CN; Sat, 02 May 2020 16:35:21 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUv68-0000kR-5A; Sat, 02 May 2020 16:34:42 +0000 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id A83552A074E; Sat, 2 May 2020 17:34:36 +0100 (BST) From: Boris Brezillon To: Kamal Dasu , Miquel Raynal , linux-mtd@lists.infradead.org Subject: [PATCH 1/3] mtd: rawnand: Add the concept of destructive operation Date: Sat, 2 May 2020 18:34:30 +0200 Message-Id: <20200502163432.1543243-2-boris.brezillon@collabora.com> X-Mailer: git-send-email 2.25.3 In-Reply-To: <20200502163432.1543243-1-boris.brezillon@collabora.com> References: <20200502163432.1543243-1-boris.brezillon@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200502_093440_321443_D065C4AB X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Florian Fainelli , Vignesh Raghavendra , Scott Branden , Tudor Ambarus , Ray Jui , Lee Jones , Eric Anholt , Boris Brezillon , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Richard Weinberger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Erase and program operations need the WP (Write Protect) pin to be de-asserted to take effect. Let's add the concept of destructive operation and pass the information to exec_op() so controllers know when they should de-assert this pin without having to guess it from the command opcode. Signed-off-by: Boris Brezillon --- include/linux/mtd/rawnand.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h index c47cbcb86b71..6014e7389507 100644 --- a/include/linux/mtd/rawnand.h +++ b/include/linux/mtd/rawnand.h @@ -854,6 +854,8 @@ struct nand_op_parser { /** * struct nand_operation - NAND operation descriptor * @cs: the CS line to select for this NAND operation + * @deassert_wp: set to true when the operation requires the WP pin to be + * de-asserted (ERASE, PROG, ...) * @instrs: array of instructions to execute * @ninstrs: length of the @instrs array * @@ -861,6 +863,7 @@ struct nand_op_parser { */ struct nand_operation { unsigned int cs; + bool deassert_wp; const struct nand_op_instr *instrs; unsigned int ninstrs; }; @@ -872,6 +875,14 @@ struct nand_operation { .ninstrs = ARRAY_SIZE(_instrs), \ } +#define NAND_DESTRUCTIVE_OPERATION(_cs, _instrs) \ + { \ + .cs = _cs, \ + .deassert_wp = true, \ + .instrs = _instrs, \ + .ninstrs = ARRAY_SIZE(_instrs), \ + } + int nand_op_parser_exec_op(struct nand_chip *chip, const struct nand_op_parser *parser, const struct nand_operation *op, bool check_only); -- 2.25.3 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/