From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42CFEC3A5A9 for ; Mon, 4 May 2020 10:37:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 157BC20721 for ; Mon, 4 May 2020 10:37:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tGfkPgYW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 157BC20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5lVpuFQtqmS49dFN0gVMtBwuypneg9Vi/nZsE3FRR/U=; b=tGfkPgYW1PSuCg P1hvrm6StNpDFOyaMx1D4aogUFKhr9Ug8BVuguXlJFXcotTDCh1tFqlvNBh32Pw0Izjas4SkLxaUY q+izqo/UgxJFPFvf18quRx/14xgYTgo70zg/+ATreM3UGLqeSrqpW2o+GkWDk/p3eui1Lpr3+yKYD 5HTpfa+0mBp+eK5z3e+bR/vypep+g8aHYl6JILdUx9klcUdT/neeUnxQoixGQ3tcf88YkI7ferktr DEs0jEYfrDa04IDy8//jMLm0uzYXE7HpqwYaObuQPTiv/TICKRecCMhWMSIIE/vlY2Bc1fo6ZyGD8 Egyz4JdPxdOm2kk+L1lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVYTQ-000382-BI; Mon, 04 May 2020 10:37:20 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVYTN-00037B-SI for linux-mtd@lists.infradead.org; Mon, 04 May 2020 10:37:19 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 079F12A0EFD; Mon, 4 May 2020 11:37:16 +0100 (BST) Date: Mon, 4 May 2020 12:37:13 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v4 07/13] mtd: rawnand: Add a helper to check supported operations Message-ID: <20200504123713.22c7f22f@collabora.com> In-Reply-To: <20200504095237.1654-8-miquel.raynal@bootlin.com> References: <20200504095237.1654-1-miquel.raynal@bootlin.com> <20200504095237.1654-8-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_033718_045679_81144904 X-CRM114-Status: GOOD ( 15.92 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, 4 May 2020 11:52:31 +0200 Miquel Raynal wrote: > Let's use a helper to clearly check if an operation is supported or not. > > Return -ENOTSUPP when ->exec_op() is not implemented as we cannot know. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/internals.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h > index 9d0caadf940e..b722af7a0b7e 100644 > --- a/drivers/mtd/nand/raw/internals.h > +++ b/drivers/mtd/nand/raw/internals.h > @@ -106,6 +106,15 @@ static inline bool nand_has_exec_op(struct nand_chip *chip) > return true; > } > > +static inline int nand_check_supported_op(struct nand_chip *chip, > + const struct nand_operation *op) I would just call that one nand_check_op(). > +{ > + if (!nand_has_exec_op(chip)) > + return 0; > + > + return chip->controller->ops->exec_op(chip, op, true); > +} > + > static inline int nand_exec_op(struct nand_chip *chip, > const struct nand_operation *op) > { ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/