linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Michal Simek <monstr@monstr.eu>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Naga Sureshkumar Relli <nagasure@xilinx.com>
Subject: Re: [PATCH v4 11/13] mtd: rawnand: Expose monolithic read/write_page_raw() helpers
Date: Mon, 4 May 2020 12:37:40 +0200	[thread overview]
Message-ID: <20200504123740.765c59e7@xps13> (raw)
In-Reply-To: <20200504123501.56ade217@collabora.com>


Boris Brezillon <boris.brezillon@collabora.com> wrote on Mon, 4 May
2020 12:35:01 +0200:

> On Mon,  4 May 2020 11:52:35 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> >  /**
> >   * nand_write_page_raw_syndrome - [INTERN] raw page write function
> >   * @chip: nand chip info structure
> > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > index 70380c91731c..830e05dd1e1d 100644
> > --- a/include/linux/mtd/rawnand.h
> > +++ b/include/linux/mtd/rawnand.h
> > @@ -1328,13 +1328,17 @@ int nand_read_oob_std(struct nand_chip *chip, int page);
> >  int nand_get_set_features_notsupp(struct nand_chip *chip, int addr,
> >  				  u8 *subfeature_param);
> >  
> > -/* Default read_page_raw implementation */
> > +/* Default read_page_raw implementations */  
> 
> I thought we agreed on dropping the "Default" here
> 
> >  int nand_read_page_raw(struct nand_chip *chip, uint8_t *buf, int oob_required,
> >  		       int page);
> > +int nand_monolithic_read_page_raw(struct nand_chip *chip, uint8_t *buf,
> > +				  int oob_required, int page);
> >  
> > -/* Default write_page_raw implementation */
> > +/* Default write_page_raw implementations */  
> 
> and here :).

I completely forgot about that.

If the rest is fine, I'll just resend this one (or the last patches).

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-05-04 10:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04  9:52 [PATCH v4 00/13] Supporting restricted NAND controllers Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 01/13] mtd: rawnand: Translate obscure bitfields into readable macros Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 02/13] mtd: rawnand: Reorder the nand_chip->options flags Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 03/13] mtd: rawnand: Rename a NAND chip option Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 04/13] mtd: rawnand: Fix comments about the use of bufpoi Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 05/13] mtd: rawnand: Rename the use_bufpoi variables Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 06/13] mtd: rawnand: Avoid indirect access to ->data_buf() Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 07/13] mtd: rawnand: Add a helper to check supported operations Miquel Raynal
2020-05-04 10:37   ` Boris Brezillon
2020-05-04  9:52 ` [PATCH v4 08/13] mtd: rawnand: Give the possibility to verify a read operation is supported Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 09/13] mtd: rawnand: onfi: Adapt the parameter page read to constraint controllers Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 10/13] mtd: rawnand: jedec: " Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 11/13] mtd: rawnand: Expose monolithic read/write_page_raw() helpers Miquel Raynal
2020-05-04 10:35   ` Boris Brezillon
2020-05-04 10:37     ` Miquel Raynal [this message]
2020-05-04 10:39       ` Boris Brezillon
2020-05-04  9:52 ` [PATCH v4 12/13] mtd: rawnand: Allow controllers to overload soft ECC hooks Miquel Raynal
2020-05-04  9:52 ` [PATCH v4 13/13] mtd: rawnand: micron: Allow controllers to overload raw accessors Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504123740.765c59e7@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=monstr@monstr.eu \
    --cc=nagasure@xilinx.com \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).