From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04634C47247 for ; Mon, 4 May 2020 10:38:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEBDE20721 for ; Mon, 4 May 2020 10:38:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j/iYNykW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEBDE20721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ndN6Sm5omcMxwrhFJLzLXU/x3fXyufAWfgA/usE3Cq8=; b=j/iYNykWSfZrJH RCfvk++BD1kYpxrT5F/OBhsW56YrhUhQaJFBnTxdkRELWLFXMMB1fFlEp2EK+aaQGkSmioqOByrXx zI7rnWhOxRnIzfhTh5bJ/iPpkncEx5i+ZtSTf2Sjm91F700kMpxf+MOHWA7qgM70EkXbtrSPDRPm+ O/EzIFKTHJi6SlqXFPDeABaxtDVKQ2NI5P/nV1e30233yyXl9PYsRwXjcSStQmm81M12T9HKzWoMn zL1wyBs14t5RN04FP3Fcgz82KKp+8LRK0cGeLO3dc8yZ8FOHAzgS/BtRpaGEueokgVi8LV1n0XYiO aAbk9jIiQ8hAgU3N0GHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVYTt-0003PL-Oj; Mon, 04 May 2020 10:37:49 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVYTq-0003Nz-8k for linux-mtd@lists.infradead.org; Mon, 04 May 2020 10:37:47 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 474C8240008; Mon, 4 May 2020 10:37:42 +0000 (UTC) Date: Mon, 4 May 2020 12:37:40 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v4 11/13] mtd: rawnand: Expose monolithic read/write_page_raw() helpers Message-ID: <20200504123740.765c59e7@xps13> In-Reply-To: <20200504123501.56ade217@collabora.com> References: <20200504095237.1654-1-miquel.raynal@bootlin.com> <20200504095237.1654-12-miquel.raynal@bootlin.com> <20200504123501.56ade217@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_033746_440318_ADAA01A9 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Mon, 4 May 2020 12:35:01 +0200: > On Mon, 4 May 2020 11:52:35 +0200 > Miquel Raynal wrote: > > > /** > > * nand_write_page_raw_syndrome - [INTERN] raw page write function > > * @chip: nand chip info structure > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > index 70380c91731c..830e05dd1e1d 100644 > > --- a/include/linux/mtd/rawnand.h > > +++ b/include/linux/mtd/rawnand.h > > @@ -1328,13 +1328,17 @@ int nand_read_oob_std(struct nand_chip *chip, int page); > > int nand_get_set_features_notsupp(struct nand_chip *chip, int addr, > > u8 *subfeature_param); > > > > -/* Default read_page_raw implementation */ > > +/* Default read_page_raw implementations */ > > I thought we agreed on dropping the "Default" here > > > int nand_read_page_raw(struct nand_chip *chip, uint8_t *buf, int oob_required, > > int page); > > +int nand_monolithic_read_page_raw(struct nand_chip *chip, uint8_t *buf, > > + int oob_required, int page); > > > > -/* Default write_page_raw implementation */ > > +/* Default write_page_raw implementations */ > > and here :). I completely forgot about that. If the rest is fine, I'll just resend this one (or the last patches). ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/