From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CBB6C38A2A for ; Thu, 7 May 2020 12:11:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DB6B2075E for ; Thu, 7 May 2020 12:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oV44ZkEd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DB6B2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l4cRQ8b9lIHe/p5MQAPr7WAOBm6xnZFLX2kNsguFFvU=; b=oV44ZkEdAgXMTU GYS9edeMDGS0uiQU9V9RHOgB26Z2czxQjuJ97oIjE/VnynZBJarSTGUsm1Yd7ipXA5oyUVfxSgUmK E/fN6VVTNvBi8Bh9eXqkGucMfwG87tp+NNAsI25I4UIRx7DvSDBCbbMtVIjt0iO4iH5PfSVWiV+Mg N2UqidsNV7fxSM/FmQlF+FkQvqVzRWgUY2drdsbmp5fGDbdd8sZ0Y/k9nb7aSZ1/4WQGV1VZuijDI y/A3aiWLVEJxDqmAqfJ8wLba4FhyY3+CQLAIPTtCencIIC3XEoPkwf/MVMI8zeXhxJsILdNqC3erF TeGXjaqt62FqtdxWdMTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWfMt-0000Lj-EP; Thu, 07 May 2020 12:11:11 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWfMp-0000Kl-FN for linux-mtd@lists.infradead.org; Thu, 07 May 2020 12:11:09 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id EA2C82A29CE; Thu, 7 May 2020 13:11:05 +0100 (BST) Date: Thu, 7 May 2020 14:11:03 +0200 From: Boris Brezillon To: Miquel Raynal , Mark Rutland Subject: Re: [PATCH v3 7/8] mtd: rawnand: arasan: Add new Arasan NAND controller Message-ID: <20200507141103.0c241877@collabora.com> In-Reply-To: <20200507110034.14736-8-miquel.raynal@bootlin.com> References: <20200507110034.14736-1-miquel.raynal@bootlin.com> <20200507110034.14736-8-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_051107_644861_5F650773 X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Michal Simek , Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Naga Sureshkumar Relli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, 7 May 2020 13:00:33 +0200 Miquel Raynal wrote: > + > +static void anfc_chips_cleanup(struct arasan_nfc *nfc) > +{ > + struct anand *anand, *tmp; > + > + list_for_each_entry_safe(anand, tmp, &nfc->chips, node) { > + nand_release(&anand->chip); ret = mtd_device_unregister(nand_to_mtd(&anand->chip)); WARN_ON(ret); nand_cleanup(&anand->chip); Or maybe add this WARN_ON() to nand_release() so we don't have to ask people to use mtd_device_unregister() + nand_cleanup(). We really should fix that at some point (allocate nand_chip and mtd_info separately and leave a dummy mtd_info object with all hooks returning ENODEV when the unregister fails). > + list_del(&anand->node); > + } > +} ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/