From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381B8C54E8D for ; Mon, 11 May 2020 18:27:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED2A52070B for ; Mon, 11 May 2020 18:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="edYjet2u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED2A52070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UteDbIxR9jl20OXACviIApuu6RErW0nQoIfn6km265s=; b=edYjet2uEHIeiC BH0oSw8VBU/tzDUkqUh/Uk0PjuwJ+cTIBzDZhkozBL4iGEE8vaAnY9BnrPxsFQE5LvfVO081aglVd JUGByefzBaNFwIk6YFxl2ieFlNPdk6sPXWzgi8rkItIpIEqE3T08NmngOXYuvd56zzQ0P09MjI1JQ RZgpPpLBaKCCt/EBaSXR59Dx1qkvmAFqlrRRb3dIPeZVs/chVYcLWkFEVf0u2L8Ogphwde2GTEQ6j Z+FvkIeAOhDLFzWHYD4W5JQ+XtfWgDFHo1TT/HOLo2xl38aZ8SRIVH6O+r/14Q+zHZbJc6juPET9V 02whEHjzY03fkve03ckA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYD9V-0007Mc-Es; Mon, 11 May 2020 18:27:45 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYD9A-00077H-UU for linux-mtd@lists.infradead.org; Mon, 11 May 2020 18:27:26 +0000 Received: by mail-ot1-f68.google.com with SMTP id g14so8344289otg.10 for ; Mon, 11 May 2020 11:27:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0hPBkYeKIiodMWs/enk89cPCGVXGgMcnp/mkphaKHR0=; b=lQ05+b1M2VQAKMeNo/TEGRbQg4pYZrIkcNGQtsZ11fSf4K7kqNpGFmmOjQuS/ttqWn n7QhcPQ6qnkR4leb98m8lG3T/p/if+NJ4A9gv2RpsFPoVxSTBoJGY0etarqhmv336sOX 3ICCmD+dCchXGhncvLuqyuuRar1lCzAmnXGO47u673qnlcRsY4jtTazIkdcy49scqHeX XhYw8h60jc72ztYHs9jG+gxt3U5jqrTShOG0kN/GxfJCYhwPlemtyhG8ZbVquJ77XIH+ mXcmiZE6abbnIt7WSxv2bhBBh+3gbphdSgnYKieaUair2vbN4VwGboL8L+xfkR31Hi9y dMcQ== X-Gm-Message-State: AGi0PuZqxO+CIsh09azR/OAp7BkuZMJR49H9KIO27WUjGWDsAQn5Bkid 9l9lYtKVM1ZaTFaNuVZOrnTx+no= X-Google-Smtp-Source: APiQypKkLLpfS5uFZ7qDGesr8w1obstysUYqHlic1hxCJgCQLeL+ae1OZe/dsWHP/TD49Qm1gGUNpg== X-Received: by 2002:a9d:7858:: with SMTP id c24mr13282165otm.163.1589221644004; Mon, 11 May 2020 11:27:24 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id e91sm2834465otb.40.2020.05.11.11.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 11:27:23 -0700 (PDT) Received: (nullmailer pid 6693 invoked by uid 1000); Mon, 11 May 2020 15:37:12 -0000 Date: Mon, 11 May 2020 10:37:12 -0500 From: Rob Herring To: "Ramuthevar, Vadivel MuruganX" Subject: Re: [PATCH v5 1/2] dt-bindings: mtd: Add YAML for Nand Flash Controller support Message-ID: <20200511153712.GA25497@bogus> References: <20200507001537.4034-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200507001537.4034-2-vadivel.muruganx.ramuthevar@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200507001537.4034-2-vadivel.muruganx.ramuthevar@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_112724_979737_AE498BD8 X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cheol.yong.kim@intel.com, devicetree@vger.kernel.org, qi-ming.wu@intel.com, anders.roxell@linaro.org, vigneshr@ti.com, arnd@arndb.de, hauke.mehrtens@intel.com, richard@nod.at, brendanhiggins@google.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, boris.brezillon@collabora.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, tglx@linutronix.de, masonccyang@mxic.com.tw, andriy.shevchenko@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, May 07, 2020 at 08:15:36AM +0800, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan > > Add YAML file for dt-bindings to support NAND Flash Controller > on Intel's Lightning Mountain SoC. The $subject should some how reflect this is for this SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan > --- > .../devicetree/bindings/mtd/intel,lgm-nand.yaml | 85 ++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml > new file mode 100644 > index 000000000000..69b592ae62f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel LGM SoC NAND Controller Device Tree Bindings > + > +allOf: > + - $ref: "nand-controller.yaml" > + > +maintainers: > + - Ramuthevar Vadivel Murugan > + > +properties: > + compatible: > + const: intel,lgm-nand-controller > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + dmas: > + maxItems: 2 > + > + dma-names: > + enum: > + - rx > + - tx > + > + pinctrl-names: true > + > +patternProperties: > + "^pinctrl-[0-9]+$": true Don't need the pinctrl properties. The tooling adds them. > + > + "^nand@[a-f0-9]+$": > + type: object > + properties: > + reg: > + minimum: 0 > + maximum: 7 > + > + nand-ecc-mode: true > + > + nand-ecc-algo: > + const: hw > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - dmas > + > +additionalProperties: false > + > +examples: > + - | > + #include Is this applied somewhere? It's missing in my check and will break the build. > + nand-controller@e0f00000 { > + compatible = "intel,nand-controller"; > + reg = <0xe0f00000 0x100>, > + <0xe1000000 0x300>, > + <0xe1400000 0x8000>, > + <0xe1c00000 0x1000>; > + reg-names = "ebunand", "hsnand", "nand_cs0", "nand_cs1"; > + clocks = <&cgu0 LGM_GCLK_EBU>; > + dma-names = "tx", "rx"; > + #address-cells = <1>; > + #size-cells = <0>; > + #clock-cells = <1>; > + > + nand@0 { > + reg = <0>; > + nand-on-flash-bbt; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > + }; > + > +... > -- > 2.11.0 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/