Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()

Richard Weinberger
2020-05-17T21:39:23Z

On Fri, May 15, 2020 at 10:50 PM Richard Weinberger <richard@nod.at> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "Eric Biggers" <ebiggers@kernel.org>
> > An: "Sascha Hauer" <s.hauer@pengutronix.de>, "richard" <richard@nod.at>
> > CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>, "stable"
> > <stable@vger.kernel.org>
> > Gesendet: Freitag, 15. Mai 2020 21:17:04
> > Betreff: Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()
>
> > On Mon, May 04, 2020 at 09:16:44AM +0200, Sascha Hauer wrote:
> >> On Fri, May 01, 2020 at 10:59:45PM -0700, Eric Biggers wrote:
> >> > From: Eric Biggers <ebiggers@google.com>
> >> >
> >> > crypto_shash_descsize() returns the size of the shash_desc context
> >> > needed to compute the hash, not the size of the hash itself.
> >> >
> >> > crypto_shash_digestsize() would be correct, or alternatively using
> >> > c->hash_len and c->hmac_desc_len which already store the correct values.
> >> > But actually it's simpler to just use stack arrays, so do that instead.
> >> >
> >> > Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication support")
> >> > Fixes: da8ef65f9573 ("ubifs: Authenticate replayed journal")
> >> > Cc: <stable@vger.kernel.org> # v4.20+
> >> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> >> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> >>
> >> Looks better that way, thanks.
> >>
> >> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> >>
> >
> > Richard, could you take this through the ubifs tree for 5.8?
>
> Sure. I actually will send a PR with various MTD related fixes
> for 5.7.

Applied. Thanks for fixing!

--
Thanks,
//richard